fix Webpack loader config for .vanilla.css files

seek-oss · Jul 21, 2023 · ef0a636 · ef0a636
1 parent 232ec67
commit ef0a636
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/sku/config/webpack/plugins/sku-webpack-plugin/index.js b/packages/sku/config/webpack/plugins/sku-webpack-plugin/index.js
@@ -149,12 +149,13 @@ class SkuWebpackPlugin {
       },
       {
         // All CSS created by vanilla-extract
-        test: /\.vanilla.css$/i,
+        test: /\.vanilla\.css$/i,
         // Don't process vanilla files from Playroom as they are handled separately.
         // Virtual file paths will look more realistic in the future allowing
         // more standard handling of include/exclude path matching.
         exclude: /node_modules\/playroom/,
         use: makeVanillaCssLoaders({
+          target,
           isProductionBuild,
           MiniCssExtractPlugin,
           hot,

diff --git a/packages/sku/config/webpack/utils/loaders.js b/packages/sku/config/webpack/utils/loaders.js
@@ -99,10 +99,11 @@ const makeCssLoaders = (options = {}) => {
 };
 
 const makeVanillaCssLoaders = (options = {}) => {
-  const { isProductionBuild, MiniCssExtractPlugin, browserslist } = options;
+  const { target, isProductionBuild, MiniCssExtractPlugin, browserslist } =
+    options;
 
   return [
-    MiniCssExtractPlugin.loader,
+    ...(target === 'browser' ? [MiniCssExtractPlugin.loader] : []),
     {
       loader: require.resolve('css-loader'),
       options: {