Skip to content

Commit

Permalink
Add .storybook/main.js to git and lint ignore files
Browse files Browse the repository at this point in the history
  • Loading branch information
askoufis committed Aug 25, 2023
1 parent 4ba0663 commit 77fbb6a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
4 changes: 4 additions & 0 deletions packages/sku/lib/configure.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,20 @@ const writeFileToCWD = async (fileName, content, { banner = true } = {}) => {
await writeFile(outPath, contentStr);
};

const storybookMainConfig = '.storybook/main.js';

module.exports = async () => {
// Ignore webpack bundle report output
const gitIgnorePatterns = [
addSep(bundleReportFolder),
addSep(coverageFolder),
storybookMainConfig,
];
const lintIgnorePatterns = [
addSep(bundleReportFolder),
addSep(coverageFolder),
'*.less.d.ts',
storybookMainConfig,
];

// Ignore webpack target directories
Expand Down
12 changes: 8 additions & 4 deletions tests/configure.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,10 @@ describe('configure', () => {

it(`should generate \`.gitignore\``, async () => {
const ignoreContents = await readIgnore(appFolder, '.gitignore');
expect(ignoreContents.length).toEqual(7);
expect(ignoreContents.length).toEqual(8);
expect(ignoreContents).toContain(`.eslintrc`);
expect(ignoreContents).toContain(`.prettierrc`);
expect(ignoreContents).toContain(`.storybook/main.js`);
expect(ignoreContents).toContain(`${defaultTargetDir}/`);
expect(ignoreContents).toContain(`${defaultStorybookTargetDir}/`);
expect(ignoreContents).toContain(`${bundleReportFolder}/`);
Expand All @@ -90,8 +91,9 @@ describe('configure', () => {
['.eslintignore', '.prettierignore'].forEach((ignore) =>
it(`should generate \`${ignore}\``, async () => {
const ignoreContents = await readIgnore(appFolder, ignore);
expect(ignoreContents.length).toEqual(5);
expect(ignoreContents.length).toEqual(6);
expect(ignoreContents).toContain('*.less.d.ts');
expect(ignoreContents).toContain(`.storybook/main.js`);
expect(ignoreContents).toContain(`${defaultTargetDir}/`);
expect(ignoreContents).toContain(`${bundleReportFolder}/`);
expect(ignoreContents).toContain(`${coverageFolder}/`);
Expand Down Expand Up @@ -137,10 +139,11 @@ describe('configure', () => {

it(`should generate \`.gitignore\``, async () => {
const ignoreContents = await readIgnore(appFolderTS, '.gitignore');
expect(ignoreContents.length).toEqual(7);
expect(ignoreContents.length).toEqual(8);
expect(ignoreContents).toContain(`.eslintrc`);
expect(ignoreContents).toContain(`.prettierrc`);
expect(ignoreContents).toContain(`tsconfig.json`);
expect(ignoreContents).toContain(`.storybook/main.js`);
expect(ignoreContents).toContain(`${skuConfig.target}/`);
expect(ignoreContents).toContain(`${skuConfig.storybookTarget}/`);
expect(ignoreContents).toContain(`${bundleReportFolder}/`);
Expand All @@ -150,8 +153,9 @@ describe('configure', () => {
['.eslintignore', '.prettierignore'].forEach((ignore) =>
it(`should generate \`${ignore}\``, async () => {
const ignoreContents = await readIgnore(appFolderTS, ignore);
expect(ignoreContents.length).toEqual(5);
expect(ignoreContents.length).toEqual(6);
expect(ignoreContents).toContain('*.less.d.ts');
expect(ignoreContents).toContain(`.storybook/main.js`);
expect(ignoreContents).toContain(`${skuConfig.target}/`);
expect(ignoreContents).toContain(`${skuConfig.storybookTarget}/`);
expect(ignoreContents).toContain(`${bundleReportFolder}/`);
Expand Down

0 comments on commit 77fbb6a

Please sign in to comment.