Skip to content

Commit

Permalink
Merge branch 'master' into increase-timeout
Browse files Browse the repository at this point in the history
  • Loading branch information
askoufis authored Aug 24, 2023
2 parents 4a6fe89 + 66291a6 commit 000097b
Show file tree
Hide file tree
Showing 7 changed files with 131 additions and 17 deletions.
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"release": "pnpm deploy-docs && changeset publish",
"version": "changeset version && pnpm install --lockfile-only"
},
"packageManager": "[email protected]",
"lint-staged": {
"+(package.json|pnpm-lock.yaml)": [
"pnpm run check"
Expand Down Expand Up @@ -64,8 +63,10 @@
"ts-jest": "^29.1.1"
},
"volta": {
"node": "18.16.0"
"node": "18.16.0",
"pnpm": "8.6.12"
},
"packageManager": "[email protected]",
"skuSkipPostInstall": true,
"skuSkipConfigure": true,
"skuSkipValidatePeerDeps": true
Expand Down
8 changes: 8 additions & 0 deletions packages/sku/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# sku

## 12.3.3

### Patch Changes

- Revert storybook config to CJS ([#873](https://github.com/seek-oss/sku/pull/873))

Fixes a bug where newer storybook versions (>=7.1.0) could not load sku's storybook config

## 12.3.2

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/sku/config/storybook/build/main.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default } from '../config';
module.exports = require('../config');
15 changes: 8 additions & 7 deletions packages/sku/config/storybook/config.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import fs from 'fs';
import path from 'path';
import { createRequire } from 'module';
import { paths, storybookAddons, storybookStoryStore } from '../../context';

const require = createRequire(import.meta.url);
const fs = require('fs');
const path = require('path');
const {
paths,
storybookAddons,
storybookStoryStore,
} = require('../../context');

/** @type {import("@storybook/react-webpack5").StorybookConfig} */
export default {
module.exports = {
stories: paths.src
.filter((srcPath) => fs.statSync(srcPath).isDirectory())
.map((srcPath) => path.join(srcPath, '**/*.stories.@(js|ts|tsx)')),
Expand Down
2 changes: 1 addition & 1 deletion packages/sku/config/storybook/start/main.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default } from '../config';
module.exports = require('../config');
2 changes: 1 addition & 1 deletion packages/sku/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sku",
"version": "12.3.2",
"version": "12.3.3",
"description": "Front-end development toolkit, powered by Webpack, Babel, CSS Modules, Less and Jest",
"main": "index.js",
"bin": {
Expand Down
114 changes: 109 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 000097b

Please sign in to comment.