fix: Disable snippet previews while snippet panel is closing #371
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 14d14e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
approved these changes
Oct 10, 2024
Comment on lines
+5
to
+8
| Disable snippet previews while the snippets panel is closing. | ||
|
|
||
| Previously, snippet previews could be triggered while the snippet panel was closing, causing preview frames to enter an invalid state. | ||
| Previewing a snippet will now only work when the snippet panel is open. |
There was a problem hiding this comment.
This feels a bit too much like implementation detail to me. I'd just mention the bug and say it's fixed.
Suggested change
| Disable snippet previews while the snippets panel is closing. | |
| Previously, snippet previews could be triggered while the snippet panel was closing, causing preview frames to enter an invalid state. | |
| Previewing a snippet will now only work when the snippet panel is open. | |
| Fixes a bug that was causing duplicate snippet previews and broken preview updates when a snippet was clicked and the mouse was moved while the snippets panel was closing |
It's a bit of a long sentence, but I think it gets the point across.
Comment on lines
+146
to
+154
| isOpen && !isHighlighted | ||
| ? () => { | ||
| setHighlightedIndex(index); | ||
| } | ||
| : undefined | ||
| } | ||
| onMouseDown={() => closeHandler(filteredSnippets[index])} | ||
| onMouseDown={() => { | ||
| closeHandler(filteredSnippets[index]); | ||
| }} |
There was a problem hiding this comment.
Could make this diff smaller by removing the curly braces from the functions. Github wouldn't let me suggest a change :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #368
This issue occurs when the user moves their cursor over a snippet in the snippet panel, while the panel is closing.
This triggers the frames to enter a mode for previewing snippets, which is only ended when the snippets panel is initially closed.
This change prevents snippets from being previewed after the panel begins to close.