Save editor hidden status to Playroom url #369
Merged
+91
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b3de758 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
felixhabib
commented
Oct 8, 2024
cypress/e2e/urlHandling.cy.ts
Outdated
Comment on lines
41
to
49
| // Todo - write a test that checks the CodeMirror element is not visible | ||
| /* | ||
| The CodeMirror element is not visible, but it is in the DOM | ||
| This test fails because the element doesn't meet Cypress's requirements for being hidden | ||
| https://docs.cypress.io/guides/core-concepts/interacting-with-elements#An-element-is-considered-hidden-if | ||
| */ | ||
| // cy.get('.CodeMirror-code').should('be.hidden'); | ||
| }); |
There was a problem hiding this comment.
This is proving very difficult to test. I don't think it is worth holding up the release unless there is an easy fix
askoufis
approved these changes
Oct 10, 2024
| // Todo - write a test that checks the CodeMirror element is not visible | ||
| /* | ||
| The CodeMirror element is not visible, but it is in the DOM | ||
| This test fails because the element doesn't meet Cypress's requirements for being hidden |
There was a problem hiding this comment.
Could be worth clarifying that we don't know what's causing it to fail the hidden requirement either.
felixhabib
force-pushed
the
save-editorHidden-status
branch
from
9323cbb
to
3c8e02f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changeset
Last feature I want to get in before cutting a release