Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preinstall #13

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Remove preinstall #13

merged 2 commits into from
Apr 8, 2024

Conversation

samchungy
Copy link
Collaborator

Requested by @askoufis

@samchungy samchungy requested a review from renkoh April 8, 2024 05:24
@samchungy samchungy enabled auto-merge (squash) April 8, 2024 05:26
@samchungy samchungy merged commit be07014 into master Apr 8, 2024
2 checks passed
@samchungy samchungy deleted the fix-script branch April 8, 2024 06:03
@askoufis
Copy link

askoufis commented Apr 8, 2024

For context, these kind of local-dev restrictions should be done in the prepare script, rather than postinstall, so it only runs during a local install and not on a consumer's machine, where it may error if for example they're using yarn and non pnpm.

yarn doesn't even support prepare though, and honestly these kinds of scripts are too pedantic for my taste, so 🔥 is the only solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants