Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace protocol in public packages #204

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Aug 22, 2024

Workspace protocol

The version packages PR is failing to be created. I think this has been caused by moving to pnpm v9. It seem like the dependency version of core is being updated in changeset version, and pnpm now tries to fetch that from npm rather than using the workspace version.

Now that we're on pnmp v9, we should lean into the workspace: protocol for public packages that depend on other public workspace packages, e.g. cli depends on core.

Other

I've also updated the changesets CLI and the changesets config schema version.

@askoufis askoufis requested a review from a team as a code owner August 22, 2024 03:10
Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: fc7757e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@askoufis askoufis enabled auto-merge (squash) August 22, 2024 03:11
@askoufis askoufis merged commit 6cfe65e into master Aug 22, 2024
10 of 11 checks passed
@askoufis askoufis deleted the use-workspace-protocol branch August 22, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants