Skip to content

Commit

Permalink
Correctly generate import paths in stub entry points for deeply neste…
Browse files Browse the repository at this point in the history
…d entries (#184)
  • Loading branch information
mrm007 authored Feb 14, 2024
1 parent 9f5e6c0 commit e00526c
Show file tree
Hide file tree
Showing 8 changed files with 48 additions and 43 deletions.
5 changes: 5 additions & 0 deletions .changeset/lazy-rockets-tease.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@crackle/core': patch
---

Correctly generate import paths in stub entry points for deeply nested entries
2 changes: 1 addition & 1 deletion fixtures/dev-entries/.gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# managed by crackle
/cli
/deep/re-export
/dist
/re-export
# end managed by crackle
14 changes: 7 additions & 7 deletions fixtures/dev-entries/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
"import": "./dist/cli.mjs",
"require": "./dist/cli.cjs"
},
"./re-export": {
"./deep/re-export": {
"types": {
"import": "./dist/re-export.d.mts",
"require": "./dist/re-export.d.ts"
"import": "./dist/deep/re-export.d.mts",
"require": "./dist/deep/re-export.d.ts"
},
"import": "./dist/re-export.mjs",
"require": "./dist/re-export.cjs"
"import": "./dist/deep/re-export.mjs",
"require": "./dist/deep/re-export.cjs"
},
"./package.json": "./package.json"
},
Expand All @@ -36,8 +36,8 @@
"types": "./dist/index.d.ts",
"files": [
"cli",
"dist",
"re-export"
"deep/re-export",
"dist"
],
"scripts": {
"dev": "crackle dev",
Expand Down
1 change: 1 addition & 0 deletions fixtures/dev-entries/src/entries/deep/re-export.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from '../../index';
1 change: 0 additions & 1 deletion fixtures/dev-entries/src/entries/re-export.ts

This file was deleted.

2 changes: 1 addition & 1 deletion packages/core/src/utils/dev-entry-points.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const getHookLoader = async (
format: Format,
): Promise<HookLoader> => {
const stringifyRelative = (p: string) =>
JSON.stringify(path.relative(entry.outputDir, p));
JSON.stringify(path.relative(entry.packageDir, p));

const config = getConfigFromContext();

Expand Down
33 changes: 33 additions & 0 deletions tests/__snapshots__/dev/dev-entries/dist/deep/re-export.ts.snap
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/* #region dist/deep/re-export.cjs */
require("../../../../node_modules/.pnpm/tsx@[version]/node_modules/tsx/dist/cjs/index.cjs");

const _mod = require("../../src/entries/deep/re-export.ts");

module.exports = _mod;
/* #endregion */


/* #region dist/deep/re-export.d.mts */
export * from "../../src/entries/deep/re-export";
export { default } from "../../src/entries/deep/re-export";
/* #endregion */


/* #region dist/deep/re-export.d.ts */
export * from "../../src/entries/deep/re-export";
export { default } from "../../src/entries/deep/re-export";
/* #endregion */


/* #region dist/deep/re-export.mjs */
import { createRequire } from "module";

const require = createRequire(import.meta.url);

require("../../../../node_modules/.pnpm/tsx@[version]/node_modules/tsx/dist/cjs/index.cjs");

const _mod = require("../../src/entries/deep/re-export.ts");

export const something = _mod.something;
export default _mod.default;
/* #endregion */
33 changes: 0 additions & 33 deletions tests/__snapshots__/dev/dev-entries/dist/re-export.ts.snap

This file was deleted.

0 comments on commit e00526c

Please sign in to comment.