Actually run all linters in CI (#160)

.depcheckrc.yml

@@ -2,9 +2,10 @@ ignores:
   # used on release
   - '@changesets/changelog-github'
   # internal packages
+  - '@crackle-private/bootstrap'
   - '@crackle/cli'
   - '@crackle/core'
-  - '@crackle/router'
+  - '@crackle/router' # broken code that needs to be updated in packages/router/src/entries/routes.ts
   # testing
   - vitest
   - '~utils'

.eslintrc

@@ -42,7 +42,10 @@
   },
   "settings": {
     "jest": {
-      "version": 27 // otherwise ESLint fails because it can't detect Jest version
+      "version": 29 // otherwise ESLint fails because it can't detect Jest version
+    },
+    "react": {
+      "version": "18" // suppress ESLint warning about missing React version
     }
   }
 }

.github/workflows/ci.yml

@@ -63,14 +63,8 @@ jobs:
           key: build-${{ github.sha }}
           enableCrossOsArchive: true
 
-      - name: ESLint
-        run: pnpm lint:eslint
-
-      - name: Prettier
-        run: pnpm lint:prettier
-
-      - name: TypeScript
-        run: pnpm lint:tsc
+      - name: Run All Linters
+        run: pnpm lint
 
   test:
     name: Test

package.json

@@ -48,7 +48,7 @@
     "@preconstruct/eslint-plugin-format-js-tag": "^0.4.0",
     "depcheck": "^1.4.7",
     "eslint": "^8.54.0",
-    "eslint-config-seek": "^11.3.1",
+    "eslint-config-seek": "^12.1.1",
     "ignore-sync": "^7.0.1",
     "prettier": "^2.8.8",
     "tsx": "^4.3.0",

packages/babel-plugin-remove-exports/src/index.ts

@@ -4,9 +4,9 @@ import type { NodePath, Visitor } from '@babel/traverse';
 interface Context extends PluginPass {
   identifiersToKeep: Set<string>;
   opts: {
-    retainExports?: Array<string>;
+    retainExports?: string[];
     retainDefault?: boolean;
-    retainIdentifiers?: Array<string>;
+    retainIdentifiers?: string[];
   };
 }
 

packages/core/entries/render/css-extractor.ts

@@ -9,7 +9,7 @@ function stringifyFileScope({ packageName, filePath }: FileScope): string {
   return packageName ? `${filePath}$$$${packageName}` : filePath;
 }
 
-const bufferedCSSObjs = new Map<string, Array<CSSObj>>();
+const bufferedCSSObjs = new Map<string, CSSObj[]>();
 const cssByFileScope = new Map<string, string>();
 const localClassNames = new Set<string>();
 const composedClassLists = new Array<any>();

packages/core/src/types.ts

@@ -19,11 +19,11 @@ export interface CrackleServer {
   close: () => Promise<void>;
 }
 
-export type PackageEntryPoint = {
+export interface PackageEntryPoint {
   isDefaultEntry: boolean;
   entryName: string;
   entryPath: string;
   outputDir: string;
   packageDir: string;
   getOutputPath: (format: Format, options?: { from?: string }) => string;
-};
+}

packages/core/src/utils/setup-package-json.ts

@@ -23,11 +23,11 @@ export type Difference =
   | { key: 'order' };
 
 type ExportString = `./${string}`;
-type ExportObject = {
+interface ExportObject {
   types: ExportString | Omit<ExportObject, 'types'>;
   import: ExportString;
   require: ExportString;
-};
+}
 type Exports = Record<string, ExportString | ExportObject>;
 
 const structuredClone = global.structuredClone ?? structuredClonePolyfill;
@@ -74,7 +74,7 @@ const getExportsForPackage = (entries: Entry[], options: { from: string }) => {
   }
   exports[makeRelative('package.json')] = makeRelative('package.json');
 
-  return exports;
+  return exports as PackageJson['exports'];
 };
 
 const getSideEffectsForPackage = (
@@ -259,7 +259,7 @@ export const updatePackageJsonExports = async (
   }
   packageExports[lastKey] = lastExport;
 
-  packageJson.exports = packageExports;
+  packageJson.exports = packageExports as PackageJson['exports'];
 
   await writePackageJson({
     dir: packageRoot,