code review feedback

seek-oss · Jun 26, 2023 · 1b26dd1 · 1b26dd1
1 parent 732c23c
commit 1b26dd1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/fixtures/dts-compat/crackle.config.ts b/fixtures/dts-compat/crackle.config.ts
@@ -1,5 +1,5 @@
 import { defineConfig } from '@crackle/cli/config';
 
 export default defineConfig({
-  dtsMode: 'declaration',
+  dtsMode: 'preserve',
 });
diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts
@@ -58,11 +58,11 @@ export interface Config {
    * Controls how Crackle generates `.d.ts` files.
    *
    * - 'bundle' rolls up all `.d.ts` files into a single file
-   * - 'declaration' generates `.d.ts` files for each file in the source directory, for maximum compatibility with TypeScript
+   * - 'preserve' generates `.d.ts` files for each file in the source directory, for maximum compatibility with TypeScript
    *
    * @default 'bundle'
    */
-  dtsMode: 'bundle' | 'declaration';
+  dtsMode: 'bundle' | 'preserve';
   /**
    * Override TypeScript `compilerOptions` for when generating `.d.ts` files.
    *

diff --git a/packages/core/src/package-utils/dts.ts b/packages/core/src/package-utils/dts.ts
@@ -46,7 +46,7 @@ export const createDtsBundle = async (
     exports: 'named',
     format: 'esm',
     experimentalMinChunkSize: Infinity,
-    ...(config.dtsMode === 'declaration'
+    ...(config.dtsMode === 'preserve'
       ? {
           preserveModules: true,
           entryFileNames: `[name].${extensionForFormat('dts')}`,