Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: skuba 8.0.0 #26

Merged
merged 1 commit into from
Mar 28, 2024
Merged

deps: skuba 8.0.0 #26

merged 1 commit into from
Mar 28, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 25, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
skuba 7.5.0 -> 8.0.0 age adoption passing confidence

Release Notes

seek-oss/skuba (skuba)

v8.0.0

Compare Source

This version of skuba looks more scary than it is. The major change is that our dependencies have bumped their minimum Node.js requirement from 18.12 to 18.18. Most SEEK projects do not pin minor Node.js versions and are unlikely to be affected by this change.

In the spirit of upgrades, we recently refreshed our ARM64 migration guide and also have one for pnpm. A previous release landed a skuba migrate command to simplify upgrades to Node.js 20 (active LTS) before Node.js 18 reaches EOL in April 2025.

Major Changes
  • deps: eslint-config-seek 13 + eslint-config-skuba 4 + typescript-eslint ^7.2.0 (#​1487)

    These major upgrades bump our minimum requirement from Node.js 18.12 to 18.18.

    See the typescript-eslint v7 announcement for more information, and consider upgrading your project to the active LTS release with skuba migrate before Node.js 18 reaches EOL in April 2025.

Minor Changes
  • deps: semantic-release 22 (#​1492)

  • deps: TypeScript 5.4 (#​1491)

    This major release includes breaking changes. See the TypeScript 5.4 announcement for more information.

Patch Changes
  • template: Remove BUILDPLATFORM from Dockerfiles (#​1350)

    Previously, the built-in templates made use of BUILDPLATFORM and a fallback value:

    FROM --platform=${BUILDPLATFORM:-arm64} gcr.io/distroless/nodejs20-debian11
    1. Choose the platform of the host machine running the Docker build. An AWS Graviton Buildkite agent or Apple Silicon laptop will build under arm64, while an Intel laptop will build under amd64.
    2. Fall back to arm64 if the build platform is not available. This maintains compatibility with toolchains like Gantry that lack support for the BUILDPLATFORM argument.

    This approach allowed you to quickly build images and run containers in a local environment without emulation. For example, you could docker build an arm64 image on an Apple Silicon laptop for local troubleshooting, while your CI/CD solution employed amd64 hardware across its build and runtime environments. The catch is that your local arm64 image may exhibit different behaviour, and is unsuitable for use in your amd64 runtime environment without cross-compilation.

    The built-in templates now hardcode --platform as we have largely converged on arm64 across local, build and runtime environments:

    FROM --platform=arm64 gcr.io/distroless/nodejs20-debian11

    This approach is more explicit and predictable, reducing surprises when working across different environments and toolchains. Building an image on a different platform will be slower and rely on emulation.

  • Jest.mergePreset: Fudge Node16 and NodeNext module resolutions (#​1481)

    This works around a ts-jest issue where test cases fail to run if your moduleResolution is set to a modern mode:

    {
      "compilerOptions": {
        "moduleResolution": "Node16 | NodeNext"
      }
    }
    error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.
    error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'.
  • pkg: Exclude jest/*.test.ts files (#​1481)

  • template: Remove account-level tags from resources (#​1494)

    This partially reverts #​1459 and #​1461 to avoid unnecessary duplication of account-level tags in our templates.

v7.5.1

Compare Source

Patch Changes
  • template/lambda-sqs-worker: Comply with latest AWS tagging guidance (#​1461)

  • GitHub.putIssueComment: Support userId: 'seek-build-agency' (#​1474)

    The userId parameter is an optimisation to skip user lookup. A descriptive constant is now supported on SEEK build agents:

    await GitHub.putIssueComment({
      body,
    - userId: 87109344, // https://api.github.com/users/buildagencygitapitoken[bot]
    + userId: 'seek-build-agency',
    });
  • deps: Remove why-is-node-running (#​1476)

    why-is-node-running was previously added to the skuba CLI to troubleshoot scenarios where commands were timing out in CI. This has now been removed to avoid disruption to commands such as jest --detectOpenHandles.

  • deps: Remove fdir (#​1463)

    This dependency is no longer used internally.

  • template/*-rest-api: Comply with latest AWS tagging guidance (#​1459)

    This includes an upgrade to Gantry v3.

  • deps: @​octokit/graphql ^8.0.0 (#​1473)

  • deps: @​octokit/graphql-schema ^15.3.0 (#​1473)


Configuration

📅 Schedule: Branch creation - "after 3:00 am and before 6:00 am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 25, 2024 16:11
Copy link

changeset-bot bot commented Mar 25, 2024

⚠️ No Changeset found

Latest commit: 108ae5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate-skuba-8.x branch from e0f42a9 to 108ae5c Compare March 28, 2024 02:28
@askoufis askoufis merged commit 6750007 into master Mar 28, 2024
3 checks passed
@askoufis askoufis deleted the renovate-skuba-8.x branch March 28, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant