useToast: Support dynamic dismiss timeout duration #1637
+31
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0621d6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
felixhabib
commented
Oct 22, 2024
| @@ -15,6 +15,7 @@ export const useTimeout = ({ onTimeout, duration }: UseTimeoutProps) => { | |||
|
|
|||
| useEffect(() => { | |||
| if (activated) { | |||
| setActivated(true); | |||
There was a problem hiding this comment.
One method of having the toast work on the docs site in local dev. Was hitting an issue with strict mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all toasts would automatically dismiss after 10 seconds.
This update adjusts the timeout duration for toasts based on their content length, ensuring users have enough time to read the message, while minimising the time content is obscured by the toast.
Think actionable toasts should get a longer timeout
Timeout length is based off this calculation referenced here.