Skip to content

Commit

Permalink
fix: Make 'react' a peer dependency, use yarn lock file (#4)
Browse files Browse the repository at this point in the history
  • Loading branch information
jahredhope authored and markdalgleish committed Oct 2, 2018
1 parent 2669170 commit dee1715
Show file tree
Hide file tree
Showing 5 changed files with 12,786 additions and 7 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ node_modules/
dist/
report/
package-lock.json
yarn.lock
*.log
.DS_Store
.vscode/
Expand Down
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
language: node_js
cache: yarn
notifications:
email: false
before_script:
Expand Down
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,13 @@ export default () => (

## Local Development

This project uses [Yarn](https://yarnpkg.com) for development dependencies.

Installing with `yarn` is required to ensure dependencies match the current [yarn.lock](./yarn.lock).

```bash
$ npm install
$ npm start
$ yarn
$ yarn start
```

## License
Expand Down
11 changes: 7 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "lib/components/index.js",
"sideEffects": false,
"scripts": {
"test": "npm run lint && CI=true npm run unit && npm run build",
"test": "yarn check --integrity && npm run lint && CI=true npm run unit && npm run build",
"unit": "sku test",
"build": "rimraf docs/dist && sku build",
"start": "sku start",
Expand Down Expand Up @@ -37,8 +37,10 @@
"dependencies": {
"basekick": "^3.0.0",
"classnames": "^2.2.6",
"prop-types": "^15.6.2",
"react": "^16.5.2"
"prop-types": "^15.6.2"
},
"peerDependencies": {
"react": "^16.0.0"
},
"devDependencies": {
"@commitlint/cli": "^7.1.2",
Expand All @@ -49,7 +51,8 @@
"deep-keys": "^0.5.0",
"husky": "^1.0.1",
"lodash": "^4.17.11",
"react-dom": "16.5.2",
"react": "^16.5.2",
"react-dom": "^16.5.2",
"react-testing-library": "^5.1.0",
"renovate-config-seek": "0.3.0",
"rimraf": "^2.6.2",
Expand Down
Loading

0 comments on commit dee1715

Please sign in to comment.