Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🩹 update verify_properties_are_well_formed() based on changes to the Properties classes #832

Merged
merged 6 commits into from
Nov 3, 2024
Merged

fix: 🩹 update verify_properties_are_well_formed() based on changes to the Properties classes #832

merged 6 commits into from
Nov 3, 2024

Commits on Nov 1, 2024

  1. feat: ✨ add "type" to validate function to specify what is validated

    @signekb
    signekb committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    311c52e View commit details
    Browse the repository at this point in the history

  2. feat: ✨ remove errors based on required fields 

    We want this function to "focus" on whether the given properties are well-formed. Not whether they are complete; we have the verify_properties_are_complete for that.
    @signekb
    signekb committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e113276 View commit details
    Browse the repository at this point in the history

  3. feat: ✨ specify that empty properties are not well-formed properties

    @signekb
    signekb committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2ee3d72 View commit details
    Browse the repository at this point in the history

  4. test: ✏️ rename test to be more accurate

    @signekb
    signekb committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    38afbc3 View commit details
    Browse the repository at this point in the history

  5. test: ✅ update to add resources field, since it's no longer present s… 

    …ince we use the compact_dict representation
    @signekb
    signekb committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    28bde24 View commit details
    Browse the repository at this point in the history

  6. test: ✅ add test that throws error with empty properties

    @signekb
    signekb committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a2066e6 View commit details
    Browse the repository at this point in the history