Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type alias to struct #595

Merged
merged 5 commits into from
Apr 3, 2021
Merged

Change type alias to struct #595

merged 5 commits into from
Apr 3, 2021

Conversation

zakaluka
Copy link
Contributor

@zakaluka zakaluka commented Apr 2, 2021

No description provided.

@zakaluka
Copy link
Contributor Author

zakaluka commented Apr 2, 2021

Currently, cargo make verify fails because of an implicit-clone

    Checking gloo-events v0.1.1
    Checking gloo-timers v0.2.1
    Checking gloo-file v0.1.0
error: implicitly cloning a `Blob` by calling `to_owned` on its dereferenced type
  --> src\browser\web_socket\message.rs:51:51
   |
51 |             let blob = gloo_file::Blob::from(blob.to_owned());
   |                                                   ^^^^^^^^ help: consider using: `clone`
   |
   = note: `-D clippy::implicit-clone` implied by `-D clippy::pedantic`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

error: aborting due to previous error

error: could not compile `seed`

@zakaluka
Copy link
Contributor Author

zakaluka commented Apr 2, 2021

This is for seed-rs/seed-quickstart#29

@MartinKavik
Copy link
Member

Feel free to fix it according to the Clippy's suggestions :)

@zakaluka
Copy link
Contributor Author

zakaluka commented Apr 2, 2021

After I switched to the stable toolchain, the clippy error disappeared. Hopefully this one is good to go.

@MartinKavik MartinKavik merged commit c18201b into seed-rs:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants