-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change type alias to struct #39
Conversation
For #29 |
Hi @zakaluka and thanks for the PR. Please make sure it's compilable, formatted and you should be able to remove some unnecessary Clippy attributes like |
I am not able to compile this - trying to figure out how to update the |
It should work mainly on stable Rust. Nightly isn't required. |
It looks like this is failing on Stable as well. Apparently Should I try to use an older version of Rust to try and compile this? |
Oddly enough ... when I build |
I see. However it looks like they've fixed our older dependency issues and it's compilable for me when I delete |
Thanks @MartinKavik . Cargo.lock is fixed and a test from my fork was successful. |
Remove please Model {
counter: 0
} and we should be ready to go. |
Could you finish it and squash commits when you have time? I would like to merge it and resolve the dependency problem. Thanks! |
Will do. I will update all 3 areas. |
I need to update the "Model" page on the guide. I will do that as part of this commit as well. Will let you know once I've tested it. |
@MartinKavik 4 items have been updated, all linked to #29 in 3 separate pull requests. 2 commit checks are still running (seed and seed-rs.org). Please let me know if you see any other issues. |
@MartinKavik also, in terms of squashing - I think you have that option when merging the PR. I tried to squash on seed but I'm not sure it did what you wanted. |
The result should be one force-pushed commit. It's basically a two-clicks operation if you use something like GitKraken. However I can live with a couple of "weird" commits, I don't want to torture you with too many "administrative tasks". Almost all my repos allow only rebasing. All PRs now look good if I don't overlook something. I'll merge them once all pipelines pass. Thanks! |
I will try GitKraken next time - thanks for the pointer |
No description provided.