Update *.conf files to use applicable -style properties

[darcyparker]

See #22

status-attr, window-status-fg, window-status-bg, window-status-current-fg, window-status-current-bg, pane-border-fg, pane-active-border-fg, message-bg and message-fg have been removed from tmux.

See tmux/tmux@f34ebfe

[antoineco]

I believe those could be updated as well for the sake of consistency. Tmux 2.9 doesn't complain about them, but it's just a matter of time :)

[antoineco]

Suggested change

	set-option -g status-bg colour235 #base02
	set-option -g status-style bg=colour235 #base02

[antoineco]

Suggested change

	set-option -g status-fg colour136 #yellow
	set-option -g status-style fg=colour136 #yellow

[darcyparker]

@antoineco - thanks for suggestion. I made those quick changes in
fdb633f

[oconnor663]

I'm noticing a difference before and after, though I'm sure what's causing it. This PR fixes the invalid option errors I was getting with the update to tmux 2.9, but the color change seems to happen regardless of whether I'm seeing errors. (My only color configuration is source-file tmuxcolors-dark.conf.) Here's the before:

And here's after:

So previously my active window was red and the rest were gray, but now everything's yellow. Is that expected?

[antoineco]

but now everything's yellow. Is that expected?

Nice catch, it's indeed not intended to be that way.

@darcyparker it works it you set all styles in 1 single command:

set-window-option -g window-status-current-style fg=brightred,bg=default

[antoineco]

The second command overrides the first, parameters must be inlined:

Suggested change

	set-option -g status-style bg=colour235 #base02
	set-option -g status-style bg=colour235,fg=colour136 #base02,yellow

[darcyparker]

@oconnor663 - thanks for pointing out that problem. And @antoineco - thanks for hint on how to fix it. See latest commit 7849dba.

[oconnor663]

Seems to fix the problem! Thanks for the incredibly rapid response :)

[Xuanwo]

ping @seebi , This pr looks great for now, let's get this merged?

[rbjorklin]

Since brightred is used to indicate the active window in window-status-current-style would it make sense to switch the colors around for pane numbers to be consistent? See these lines

[darcyparker]

@rbjorklin - This pull request is about fixing: "Invalid options that were deprecated and removed from tmux" #22

I made no change to the lines you referred to and there was not problem with those options being deprecated/removed. Compare it to what's on master: https://github.com/seebi/tmux-colors-solarized/blob/master/tmuxcolors-dark.conf#L26-L28

I am not sure about why the existing/current color choices are the way they are... It could be interesting to explore the idea of switching the colors as you suggested. But I would make it a separate pull request/issue. The scope of that change is different than what this pull request is solving.

[marczych]

Works great for me! Time to merge it? =)

[seebi]

works for me as well