Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add mimo adapter #69

Merged
merged 27 commits into from
Apr 15, 2024
Merged

Feature/add mimo adapter #69

merged 27 commits into from
Apr 15, 2024

Conversation

henhuy
Copy link
Contributor

@henhuy henhuy commented Feb 28, 2024 •
edited
Loading

Closes #68
Depends on #67 #66 #71

@henhuy henhuy self-assigned this Feb 28, 2024
@henhuy henhuy force-pushed the feature/add_mimo_adapter branch 6 times, most recently from d20eb09 to 5cb672a Compare February 29, 2024 16:16
@nailend nailend self-requested a review March 4, 2024 15:53
@henhuy henhuy force-pushed the feature/add_mimo_adapter branch from 5cb672a to 71908de Compare March 4, 2024 15:54
@henhuy henhuy marked this pull request as ready for review March 4, 2024 15:55
@nailend nailend changed the base branch from dev to feature/refactor_mapping_into_adapter March 5, 2024 14:04
@nailend
Copy link
Contributor

nailend commented Mar 5, 2024 •
edited
Loading

I changed the base to not only see the necessary changes as features/refactor_mapping_into_adapter isn't merged yet. Switch back before merging!

nailend
nailend suggested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@nailend nailend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • poetry.lock is not consistent with pyproject.toml.
  • cant try the example as I don't have the sheet Processes_steel_industry_2

Looking forward to using it :)

@henhuy
Copy link
Contributor Author

henhuy commented Mar 13, 2024

I added structure file and adapted industry example to use newly added file.
Hopefully, it works on your side now

Base automatically changed from feature/refactor_mapping_into_adapter to dev March 13, 2024 12:35
@FelixMau
Copy link
Contributor

From my point of view this is looking good so far.
Yet some issues (#65, #74) are in the created example I think we should focus on those in seperate PR(s).

@FelixMau FelixMau requested a review from nailend March 15, 2024 09:04
nailend
nailend suggested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@nailend nailend left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few buses are not yet matched/found some processes (x2x_import_h2, x2x_import_natural_gas, excess_co2, excess_ch4, excess_n2o) is this intended?

Should we add a script to test tabular import as well? This might lead to further adjustments and make the PR prolong.

@henhuy
Copy link
Contributor Author

henhuy commented Apr 15, 2024

I would merge this right now - as I think it should be working and missing processes have to be covered elsewhere.
We can open a new PR if something is broken.

@henhuy henhuy merged commit 8e3a976 into dev Apr 15, 2024
2 checks passed
@henhuy henhuy deleted the feature/add_mimo_adapter branch April 15, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMau FelixMau FelixMau left review comments

@nailend nailend nailend requested changes

Assignees

@henhuy henhuy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MIMO adapter
3 participants
@henhuy @nailend @FelixMau