generated from rl-institut/rli_template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend mock #62
Merged
Merged
Extend mock #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing save function and integrate time_series_aggregation method. Addint tsam to poetry Updating Poetry
This is helptful to reuse in tsam test writing or in more tests to come. Mock might also easily be modified and extended this way.
This issue is fixed in another Branch.
Added a second timeseries to catch more errors and test tsam integration properly.
Also adding load process as sink.
henhuy
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am refactoring the tests approach to be able to reach Mock for different tests.
More over extending Mock for an additional volatile element including timeseries as well as Load component.
The Mock is also moved to another python test file for more tidy look and smooth navigation.
Type and name columns added to the mock as a first step for being able to create
EnergySystem.from_datapackage
directly.Solving #61 note that checks will fail as mentioned in #61