Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend mock #62

Merged
merged 14 commits into from
Nov 29, 2023
Merged

Extend mock #62

merged 14 commits into from
Nov 29, 2023

Conversation

FelixMau
Copy link
Contributor

@FelixMau FelixMau commented Nov 28, 2023

Here I am refactoring the tests approach to be able to reach Mock for different tests.

More over extending Mock for an additional volatile element including timeseries as well as Load component.
The Mock is also moved to another python test file for more tidy look and smooth navigation.

Type and name columns added to the mock as a first step for being able to create EnergySystem.from_datapackage directly.

Solving #61 note that checks will fail as mentioned in #61

Changing save function and integrate time_series_aggregation method.
Addint tsam to poetry
Updating Poetry
This is helptful to reuse in tsam test writing or in more tests to come. Mock might also easily be modified and extended this way.
This issue is fixed in another Branch.
Added a second timeseries to catch more errors and test tsam integration properly.
Also adding load process as sink.
@FelixMau FelixMau requested review from henhuy and nailend November 28, 2023 14:04
Copy link
Contributor

@henhuy henhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for refactoring

@FelixMau FelixMau merged commit 16415b2 into dev Nov 29, 2023
1 of 3 checks passed
@henhuy henhuy deleted the Extend_Mock branch December 7, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants