Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Mappers, fix bugs #59

Merged
merged 40 commits into from
Jan 12, 2024
Merged

Extend Mappers, fix bugs #59

merged 40 commits into from
Jan 12, 2024

Conversation

FelixMau
Copy link
Contributor

@FelixMau FelixMau commented Nov 9, 2023

Datapackage can be created succesfully.

Goal here is to modify the Mappers to create a datapackage where a Model can be created from for the Hack-a-thon test data.

  • goal data has to be verified
  • Energysystem model should be build from tabular

@FelixMau FelixMau self-assigned this Nov 9, 2023
@FelixMau
Copy link
Contributor Author

FelixMau commented Nov 14, 2023

Energysystem model building left for check from tabular deseralization expert @nailend
I run into an error while creating "timeincrements"

Edit: I did not notice I should name the increment on periods csv "increment" instead of "timeincrement"

@FelixMau FelixMau requested review from nailend and henhuy November 22, 2023 14:01
@nailend
Copy link
Contributor

nailend commented Nov 22, 2023

Edit: I did not notice I should name the increment on periods csv "increment" instead of "timeincrement"

No it should actually be timeincrement @FelixMau

@henhuy
Copy link
Contributor

henhuy commented Dec 7, 2023

Looks promising! - last thing would be to fix demand sequence.

@FelixMau
Copy link
Contributor Author

@nailend For some reason when initializing the datapackage reading does not recognize storage lifetimes correctly and does not add it to storage flows.

@henhuy The pytest somehow does not fail locally but here witth an error in data_adapter:

Process
    inputs: list[str] | None = None
E   TypeError: unsupported operand type(s) for |: 'types.GenericAlias' and 'NoneType'

@henhuy
Copy link
Contributor

henhuy commented Dec 19, 2023

@henhuy The pytest somehow does not fail locally but here witth an error in data_adapter:

Process
    inputs: list[str] | None = None
E   TypeError: unsupported operand type(s) for |: 'types.GenericAlias' and 'NoneType'

Ah shit - this works only in newer python versions, see https://peps.python.org/pep-0604/
We could either skip support for python 3.9 or I have to fix it in data_adapter

@FelixMau
Copy link
Contributor Author

I think we can easily skip Python 3.9? I will upgrade to 3.10.

I would also like to skip fixing the reading of datapackage here since it seems to be a bigger issue about some data not being read in properly.

@FelixMau FelixMau marked this pull request as ready for review December 19, 2023 14:26
nailend added a commit that referenced this pull request Dec 19, 2023
Set Random value fix

Set Random value fix
@FelixMau FelixMau force-pushed the feature/fix_hack-a-thon-test branch from 37abede to 7a0d152 Compare January 10, 2024 11:23
Copy link
Contributor

@nailend nailend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Python actions will be fixed in #64

@nailend nailend merged commit 894677e into dev Jan 12, 2024
3 checks passed
@henhuy henhuy deleted the feature/fix_hack-a-thon-test branch April 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants