-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Mappers, fix bugs #59
Conversation
Energysystem model building left for check from tabular deseralization expert @nailend Edit: I did not notice I should name the increment on periods csv "increment" instead of "timeincrement" |
…to feature/fix_hack-a-thon-test # Conflicts: # tests/_files/tabular_datapackage_hack_a_thon_goal/datapackage.json
…to feature/fix_hack-a-thon-test
No it should actually be |
# Conflicts: # poetry.lock # tests/_files/build_datapackage_goal/datapackage..json
Also skipping failing test
Looks promising! - last thing would be to fix demand sequence. |
@nailend For some reason when initializing the datapackage reading does not recognize storage lifetimes correctly and does not add it to storage flows. @henhuy The pytest somehow does not fail locally but here witth an error in data_adapter:
|
Ah shit - this works only in newer python versions, see https://peps.python.org/pep-0604/ |
I think we can easily skip Python 3.9? I will upgrade to 3.10. I would also like to skip fixing the reading of datapackage here since it seems to be a bigger issue about some data not being read in properly. |
Set Random value fix Set Random value fix
37abede
to
7a0d152
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing. Python actions will be fixed in #64
Datapackage can be created succesfully.
Goal here is to modify the Mappers to create a datapackage where a Model can be created from for the Hack-a-thon test data.