Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to get es_structure from B&W share #21

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

chrwm
Copy link
Member

@chrwm chrwm commented Apr 26, 2023

Closes #20

The script merges the "Processes" table and "input_output" table.
`default` parameters are set for the processes from "Process" table.
@chrwm chrwm self-assigned this Apr 26, 2023
@chrwm chrwm requested a review from henhuy April 28, 2023 12:52
@chrwm chrwm marked this pull request as ready for review April 28, 2023 12:52
Copy link
Collaborator

@henhuy henhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading Excel and ES structure look good.
Writing structure and importing it via structure module fails due to wrong otuput type (Excel instead of CSV) and wrong delimiter (comma instead of semicolon) used.
Could you fix it?
Best would be to add test for writing structure CSV and importing ti via structure.get_energy_structure.
Therefore, see also how to add a file temporarilly (is deleted afterwards):

with tempfile.TemporaryDirectory() as tmpdirname:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to read processes table and map input&outputs to default parameter
2 participants