-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review ind sector #5
base: main
Are you sure you want to change the base?
Conversation
"your source dict is referencing column 'ef': '7UBA2023a'. Column ef does not exist in the table. Do you mean all columns that start with ef by that?"
|
Yes, exactly the column_name should be exactly the same, so the complete column name is needed |
like power sector, I also did not include wacc column for any processes in industry. Should I also include it in every process? |
The data adapter is currently implemented that |
Update:
|
Hi Christoph @chrwm, I have uploaded aggregation data for Automobile and Chemical industry. Isela is working on her data aggregation, but it is unlikely she would be able to provide those at the end of this month. |
Please check the individual commits and commit messages for what is wrong.
General Feedback
global_emission_factors
Questions
ind_automobile_boiler_space_heat_gas_0
your source dict is referencing column'ef': '7UBA2023a'
. Columnef
does not exist in the table. Do you mean all columns that start withef
by that?Generel impressions
You applied the majority of conventions already 😍 Good job!
Please, check for consistency across all your tables additionally to my remarks.