RasterDataset TS support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am94ghiassi
approved these changes
Sep 20, 2024
github-actions
bot
added
the
documentation
am94ghiassi
reviewed
Sep 23, 2024
| filename_regex = re.compile(self.filename_regex, re.VERBOSE) | ||
| file_metadata = [] | ||
| for filepath in filepaths: | ||
| match = re.match(filename_regex, filepath) |
There was a problem hiding this comment.
suggestion: match = filename_regex.match(filepath)
There was a problem hiding this comment.
This is the method used in TorchGeo, so I try to stick to that
am94ghiassi
reviewed
Sep 23, 2024
torchgeo/samplers/single.py
Outdated
| @@ -145,11 +145,8 @@ def __iter__(self) -> Iterator[BoundingBox]: | |||
| if self.dataset.return_as_ts: | |||
| mint = self.dataset.bounds.mint | |||
There was a problem hiding this comment.
After merging in main, it no longer complains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic ts support without any implementation currently in the datasets. In VERS repo, this is supported, but implementation in RasterDataset and others is still to come.
The reason for this separate PR is so that we can move on within VERS, while developing full TS in sync with TG in parallel