Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoSampler updates #2

Open
wants to merge 12 commits into
base: vers_working_branch
Choose a base branch
from
Open

GeoSampler updates #2

wants to merge 12 commits into from

Conversation

stypoumic
Copy link
Collaborator

@stypoumic stypoumic commented Sep 5, 2024 •
edited
Loading

Features:

  • Added function for saving hits of GeoSamplers in shapefile or feather files.
  • GeoSampler can now accept a list of torchgeo BoundingBox as roi allowing for multiple regions of interest in the sampler.
  • Randomly sample based on ROI instead of hits

@stypoumic stypoumic marked this pull request as ready for review September 13, 2024 12:17
sfalkena
sfalkena previously requested changes Sep 13, 2024
View reviewed changes
torchgeo/samplers/single.py Outdated Show resolved Hide resolved
torchgeo/samplers/single.py Outdated Show resolved Hide resolved
torchgeo/samplers/single.py Show resolved Hide resolved
torchgeo/samplers/single.py Show resolved Hide resolved
torchgeo/samplers/single.py Show resolved Hide resolved
torchgeo/samplers/single.py Outdated Show resolved Hide resolved
torchgeo/samplers/single.py Outdated
Comment on lines 247 to 248
print("------------------------------------")
print("Chip FID: {}".format(chip["fid"]))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debugging statements

torchgeo/samplers/single.py Outdated Show resolved Hide resolved
@sfalkena sfalkena deleted the branch vers_working_branch September 17, 2024 10:02
@sfalkena sfalkena closed this Sep 17, 2024
@sfalkena sfalkena reopened this Sep 20, 2024
@sfalkena sfalkena dismissed their stale review September 20, 2024 11:26

Dismissing own review since I'm taking up the task

@sfalkena sfalkena changed the base branch from main to vers_working_branch October 1, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfalkena sfalkena sfalkena left review comments

Assignees
No one assigned
Labels
datasets samplers testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stypoumic @sfalkena