Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-1289] Migrate to oci-ta #323

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[SECURESIGN-1289] Migrate to oci-ta #323

merged 1 commit into from
Sep 2, 2024

Conversation

bouskaJ
Copy link

@bouskaJ bouskaJ commented Aug 30, 2024

No description provided.

Copy link

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bouskaJ, JasonPowr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr JasonPowr merged commit 58382ce into main Sep 2, 2024
18 of 21 checks passed
@JasonPowr
Copy link

@bouskaJ The on-push pipelines seem to be failing

Task Statuses:
[User error] Validation failed for pipelinerun backfill-redis-on-push-xbnng with error invalid input params for task sast-snyk-check-oci-ta: missing values for these params which have no default values: [SOURCE_ARTIFACT]

Task Statuses:
[User error] Validation failed for pipelinerun rekor-cli-on-push-2bwnt with error invalid input params for task git-clone-oci-ta: missing values for these params which have no default values: [ociStorage]

Task Statuses:
[User error] Validation failed for pipelinerun rekor-server-on-push-84cjw with error invalid input params for task sast-snyk-check-oci-ta: missing values for these params which have no default values: [SOURCE_ARTIFACT]

I also missed these in the review, aplogies

@bouskaJ
Copy link
Author

bouskaJ commented Sep 2, 2024

ou, the push pipelines are risky. I am going to send a new PR with fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants