Milestone 3 completion #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## liquidity-orderbook-develop #390 +/- ##
===============================================================
+ Coverage 81.68% 82.05% +0.37%
===============================================================
Files 198 200 +2
Lines 29971 30067 +96
===============================================================
+ Hits 24481 24671 +190
+ Misses 5490 5396 -94 ☔ View full report in Codecov by Sentry. |
DrPresident
reviewed
Jan 11, 2024
| Some(e) => Ok(e), | ||
| None => Err(StdError::generic_err("Reward token storage already exists")), | ||
| }?; | ||
|
|
||
| loop { |
There was a problem hiding this comment.
I don't think this loop is needed, if it is it should be reworked to a for loop or iterating an object/series
| .may_load(deps.storage, state.epoch_index)? | ||
| .ok_or_else(|| StdError::generic_err("Reward token storage does not exist"))?; | ||
|
|
||
| loop { |
itsHaseebSaeed
merged commit 495b261
into
liquidity-orderbook-develop
10 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Query_auth
Updated lb_staking staking algorithm
Added Protections to disallow recovering the staked token