Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Report generation refactoring #104

Merged
merged 3 commits into from
Jan 18, 2019
Merged

Report generation refactoring #104

merged 3 commits into from
Jan 18, 2019

Conversation

evqna
Copy link
Contributor

@evqna evqna commented Jan 15, 2019

This PR sits on top of #78.

Enforce a consistent schema for linter reports, move presentation logic to merge_reports and counting issue levels to linter report generation.

Report merging now handles an arbitrary number of reports.

Antoine Salon added 2 commits January 17, 2019 16:12
Enforce a consistent schema for linter reports,
move presentation logic to merge_reports and
counting issue levels to linter report generation.
Report merging now handles an arbitrary number of reports.

Signed-off-by: Antoine Salon <[email protected]>
Copy link
Collaborator

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit on a newline

"nosec": 0,
"found": 0
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget about these...

@evqna evqna added this to the Initial release milestone Jan 18, 2019
Signed-off-by: Antoine Salon <[email protected]>
@evqna evqna merged commit c61f485 into securesauce:master Jan 18, 2019
@evqna evqna deleted the report_gen branch January 18, 2019 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants