Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace reconstruction: bail on parsing errors #1

Conversation

RoryBrennan-Jones
Copy link

This PR causes the program to bail on parsing errors.

Previously, the program would continue running even after a parsing error, which unnecessarily complicated debugging. With this change, this is no longer an issue.

@RoryBrennan-Jones RoryBrennan-Jones marked this pull request as ready for review June 14, 2024 17:31
@mmcloughlin mmcloughlin self-requested a review June 14, 2024 17:32
Copy link
Collaborator

@mmcloughlin mmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for making our code more robust.

@mmcloughlin mmcloughlin merged commit 18db236 into secure-foundations:trace-reconstruction Jun 14, 2024
pratapsingh1729 pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants