Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where either query points or observations have unspec… #866

Merged
merged 4 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/unit/test_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import copy

import numpy as np
import numpy.testing as npt
import pytest
import tensorflow as tf
Expand Down Expand Up @@ -68,6 +69,26 @@ def test_dataset_raises_for_different_leading_shapes(
Dataset(query_points, observations)


def test_dataset_does_not_raise_with_unspecified_leading_dimension() -> None:
query_points = tf.zeros((2, 2))
observations = tf.zeros((2, 1))

query_points_var = tf.Variable(
initial_value=np.zeros((0, 2)),
shape=(None, 2),
dtype=tf.float64,
)
observations_var = tf.Variable(
initial_value=np.zeros((0, 1)),
shape=(None, 1),
dtype=tf.float64,
)

Dataset(query_points=query_points_var, observations=observations)
Dataset(query_points=query_points, observations=observations_var)
Dataset(query_points=query_points_var, observations=observations_var)


@pytest.mark.parametrize(
"query_points_shape, observations_shape",
[
Expand Down
1 change: 1 addition & 0 deletions trieste/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def __post_init__(self) -> None:
self.query_points.shape[:-1] != self.observations.shape[:-1]
# can't check dynamic shapes, so trust that they're ok (if not, they'll fail later)
and None not in self.query_points.shape[:-1]
and None not in self.observations.shape[:-1]
):
raise ValueError(
f"Leading shapes of query_points and observations must match. Got shapes"
Expand Down
Loading