Update CONTRIBUTING.md #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstojic
reviewed
Jan 10, 2024
CONTRIBUTING.md
Outdated
|
|
||
| Run the type checker with | ||
| ```bash | ||
| $ tox -e types | ||
| ``` | ||
|
|
||
| or, if running inside a virtual environment, just | ||
| ```bash | ||
| mypy |
There was a problem hiding this comment.
I have never tried it, but can you run it for a specific file, same as for tests?
There was a problem hiding this comment.
task mypy just runs mypy at the moment, but I'll change it in case we ever change the default beahviour. And yes, you can pass in an argument; I'll mention that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs:
Summary
Update contribution guidelines to make it easier for people to get started and be involved.
Fully backwards compatible: yes
PR checklist