Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optimization of multiple points in batch spaces #787

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

khurram-ghani
Copy link
Collaborator

@khurram-ghani khurram-ghani commented Sep 26, 2023

Related issue(s)/PRs: None

Summary

Add support for batch optimization of multiple points per region/subspace in a TaggedMultiSearchSpace collection.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, just a small comment for a test
it does look like we have a right test in place, checking that all optimised points are in the right box, that should be sufficient

tests/unit/acquisition/test_optimizer.py Outdated Show resolved Hide resolved
@khurram-ghani khurram-ghani merged commit 2807b76 into develop Sep 27, 2023
12 checks passed
@khurram-ghani khurram-ghani deleted the khurram/multi_qp_tr_optimization branch September 27, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants