Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi trust regions #773

Merged
merged 41 commits into from
Aug 25, 2023
Merged

Multi trust regions #773

merged 41 commits into from
Aug 25, 2023

Commits on May 18, 2023

  1. multiTR with notebook

    Victor Picheny committed May 18, 2023
    Configuration menu
    Copy the full SHA
    905dc14 View commit details
    Browse the repository at this point in the history

  2. notebook

    Victor Picheny committed May 18, 2023
    Configuration menu
    Copy the full SHA
    5c27203 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. multi local step TREGO

    Victor Picheny committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    e46150d View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge branch 'develop' into victor/trustregions

    @hstojic
    hstojic committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ceadabe View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. merged latest develop

    @hstojic
    hstojic committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    990b6cd View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Refactor multi trust region implementation 

    Provide base abstract classes for updateable search space and multi
trust region rule.
Implement concrete classes for box multi trust region rule.
    @khurram-ghani
    khurram-ghani committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ebe27f4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into khurram/trustregions

    @khurram-ghani
    khurram-ghani committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3ff37fe View commit details
    Browse the repository at this point in the history

  3. Fix formatting in notebook & remove orig TR changes

    @khurram-ghani
    khurram-ghani committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    683eacc View commit details
    Browse the repository at this point in the history

  4. Remove redundant new assert

    @khurram-ghani
    khurram-ghani committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    809153c View commit details
    Browse the repository at this point in the history

  5. Undo earlier logging change

    @khurram-ghani
    khurram-ghani committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b6ee392 View commit details
    Browse the repository at this point in the history

  6. Workaround isort & black clash

    @khurram-ghani
    khurram-ghani committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    fcc16e2 View commit details
    Browse the repository at this point in the history

  7. Keep old ver of mypy happy

    @khurram-ghani
    khurram-ghani committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9f21527 View commit details
    Browse the repository at this point in the history

  8. Fix typo in slicing

    @khurram-ghani
    khurram-ghani committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    1762d82 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Add new collection space tests

    @khurram-ghani
    khurram-ghani committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    535dbb1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into khurram/trustregions

    @khurram-ghani
    khurram-ghani authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5b97508 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Address feedback plus other small changes 

    * Use generic search space type for MultiTrustRegionBox
* Add some private methods to TrustRegionBox
* Add kwargs to reinitialize/update
* Use American spelling
* Move helper function to utils
    @khurram-ghani
    khurram-ghani committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    c4ce7ab View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into khurram/trustregions

    @khurram-ghani
    khurram-ghani committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    20b5687 View commit details
    Browse the repository at this point in the history

  3. Add TrustRegionBox/UpdateableSearchSpace unittests

    @khurram-ghani
    khurram-ghani committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0c38efb View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Address feedback for space changes

    @khurram-ghani
    khurram-ghani committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    309ef09 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Some updates to rule/utils from feedback 

    * Rename reinitialize to initialize
* Replace get_single_model_and_dataset with generic get_value_for_tag;
  plus update unit tests
* Add unit tests for and change get_unique_points_mask implementation as
  previous version erroneously identified some points as duplicates
    @khurram-ghani
    khurram-ghani committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d58306e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Create subspaces outside the rule 

    Plus revert addition of kwargs
    @khurram-ghani
    khurram-ghani committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c2abf11 View commit details
    Browse the repository at this point in the history

  2. Fix func to work with old tensorflow 

    tf.sqrt for array with inf returns nan in older versions.
    @khurram-ghani
    khurram-ghani committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    12c8f1f View commit details
    Browse the repository at this point in the history

  3. Add rule and optimizer unit tests

    @khurram-ghani
    khurram-ghani committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3c725bd View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Add integ test

    @khurram-ghani
    khurram-ghani committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    be06c63 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into khurram/trustregions

    @khurram-ghani
    khurram-ghani authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    a313bf8 View commit details
    Browse the repository at this point in the history

  3. Add shape-checking/docstring for mask func 

    Plus one other minor tweak.
    @khurram-ghani
    khurram-ghani committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0706656 View commit details
    Browse the repository at this point in the history

  4. Add check_shapes, update docstrings & add tag test

    @khurram-ghani
    khurram-ghani committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9def562 View commit details
    Browse the repository at this point in the history

  5. Remove notebook, to be added in separate PR

    @khurram-ghani
    khurram-ghani committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0973630 View commit details
    Browse the repository at this point in the history

  6. Add deepcopy test

    @khurram-ghani
    khurram-ghani committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    01f370b View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge remote-tracking branch 'origin/develop' into khurram/trustregions

    @khurram-ghani
    khurram-ghani committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    dad0936 View commit details
    Browse the repository at this point in the history

  2. Check TR copy is deep

    @khurram-ghani
    khurram-ghani committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    66b4aa4 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Improve TR box and test slightly

    @khurram-ghani
    khurram-ghani committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9bb6a80 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Address Uri's latest comments

    @khurram-ghani
    khurram-ghani committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4924557 View commit details
    Browse the repository at this point in the history

  2. Move get_value_for_tag to more general utils/misc

    @khurram-ghani
    khurram-ghani committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f0e125d View commit details
    Browse the repository at this point in the history

  3. Remove redundant [] checks

    @khurram-ghani
    khurram-ghani committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3daa81f View commit details
    Browse the repository at this point in the history

  4. Add fixture for default search space type

    @khurram-ghani
    khurram-ghani committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0b19246 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Add test for optim multiple boxes as a batch

    @khurram-ghani
    khurram-ghani committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    044f07c View commit details
    Browse the repository at this point in the history

  2. Rename classes and expand some docstrings

    @khurram-ghani
    khurram-ghani committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8ca39e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Choose longer class name

    @khurram-ghani
    khurram-ghani committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ef62eeb View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Merge branch 'develop' into khurram/trustregions

    @khurram-ghani
    khurram-ghani authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5634c85 View commit details
    Browse the repository at this point in the history

  2. Rename updatable class name

    @khurram-ghani
    khurram-ghani committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8f17839 View commit details
    Browse the repository at this point in the history