-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dependencies for Enhanced Compatibility with Newer Python Versions #5
Merged
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
2f250cf
wip
vincentadam87 67cfd46
change python versions and poetry
vincentadam87 760779e
change cmake version
vincentadam87 0a99a56
change python version
vincentadam87 1bcd32c
change python version
vincentadam87 0547e27
tf version for build
vincentadam87 76c5cce
tf version
vincentadam87 1df5d4b
tf version
vincentadam87 3a11b16
debugging with gpt
vincentadam87 04f417e
debugging with gpt v2
vincentadam87 d2c28f5
debugging with gpt v3
vincentadam87 98783c2
update mypy
vincentadam87 d4feeab
forgot the lock
vincentadam87 c9e8add
black changes
vincentadam87 e7997d0
versioning
vincentadam87 804e0d0
update pyproject
vincentadam87 3de7817
ignore banded mypy
vincentadam87 9790b57
temporary fix: skip test
vincentadam87 ccd3c82
black
vincentadam87 a93f64b
putting header back
vincentadam87 cd2740b
poetry task fix / rm setup.py / more python tested upon push
vincentadam87 45ed248
minor
vincentadam87 17f2914
change tensorflow version range
vincentadam87 99a6b31
forgot the lock
vincentadam87 dbcd088
changing tf version
vincentadam87 9c442e7
update poetry
vincentadam87 74e98be
update worflow to force the lock to be regenerate
vincentadam87 0e86957
update worflow to force the lock to be regenerate v2
vincentadam87 973048a
set matching python / tf
vincentadam87 ad19bb3
set matching python / tf
vincentadam87 2b980ca
set looser dependencies for np / tf / py
vincentadam87 1a9b267
set looser dependencies for np / tf / py
vincentadam87 55005cc
set looser dependencies for np / tf / py v2
vincentadam87 7406902
set looser dependencies for np / tf / py v3
vincentadam87 2e1cb69
reduce range and change tf/py version
vincentadam87 20401b8
workflow adding quotes to versions
vincentadam87 e6b7557
exception for python 3.8
vincentadam87 0862983
exception for python 3.8 v2
vincentadam87 9b2e8c5
looser version for mypy
vincentadam87 b314d35
now numpy
vincentadam87 fc58b05
Revert "black"
vincentadam87 47f9c03
revert to ccd3c822897cbfcb6e12c1257db2e32c69aee18c
vincentadam87 f061bf6
playing with versions
vincentadam87 14dd006
reintroducing matrix python
vincentadam87 aa38bff
version fix
vincentadam87 2ab1ae3
fixing versions tf
vincentadam87 7e403e0
black + version
vincentadam87 0ef525e
3.11
vincentadam87 9cbe714
markers
vincentadam87 a5390fe
markers weird py3.7
vincentadam87 8e5bf22
py3.11 tf2.16
vincentadam87 b271037
test
vincentadam87 2d7bf30
test back
vincentadam87 1b7e05e
remove 3.11 from list
vincentadam87 ccfa00c
fix black
vincentadam87 a5f0860
fix: john comments
vincentadam87 6080db1
py3.7
vincentadam87 6a1cd04
simplifying github workflow
vincentadam87 883f64a
gh worflow: add back manual build
vincentadam87 10f566a
gh worflow: revert to what works
vincentadam87 c3f80fb
updating release file
vincentadam87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,34 +20,53 @@ on: | |
types: | ||
- created | ||
|
||
|
||
jobs: | ||
check-and-test: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: [3.7, 3.8] | ||
poetry-version: [1.1.6] | ||
python-version: ["3.7", "3.8.12", "3.9.12", "3.10.4"] | ||
poetry-version: [1.1.12] | ||
name: Python-${{ matrix.python-version }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
# ------------ Install poetry | ||
|
||
- name: Setup pip/poetry | ||
run: | | ||
pip install -U pip poetry twine | ||
poetry config virtualenvs.create false | ||
# ------------ install tools | ||
- name: Install Python dependencies | ||
run: poetry install | ||
|
||
- name: Configure environment variables for CMake | ||
run: | | ||
echo "PYTHON_BIN=$(which python)" >> $GITHUB_ENV | ||
- name: Install building tools | ||
run: | | ||
sudo apt-get install build-essential | ||
sudo apt-get install cmake g++-11 | ||
# ------------ build and install package | ||
sudo apt-get update | ||
sudo apt-get install -y build-essential cmake g++-14 | ||
- name: Configure and Build C++ Library | ||
run: | | ||
mkdir -p banded_matrices/build | ||
cd banded_matrices/build | ||
cmake .. -DCMAKE_BUILD_TYPE=Release | ||
Comment on lines
+58
to
+60
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would be tempted to use the |
||
make | ||
- name: Install package | ||
run: poetry install | ||
# ------------ run tests | ||
|
||
- name: Set environment variables for tests | ||
run: | | ||
echo "LD_LIBRARY_PATH=$GITHUB_WORKSPACE/banded_matrices/build/lib:$LD_LIBRARY_PATH" >> $GITHUB_ENV | ||
- name: Run tests | ||
run: poetry run task test | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to define the environment variable in a build step specifically: https://docs.github.com/en/actions/learn-github-actions/variables#defining-environment-variables-for-a-single-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what you mean here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having a separate step to define a new environment variable and piping it into the global environment, the link describes how to add an
env
statement to the step in the github action definition for defining contextual environment variables.