Add RFF for simple additive kernels #104
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RFF support for additive kernels. Re-using the existing multi-output structure as much as possible, and generalising it.
This adds RFF for simple additive kernels only. So kernels can now be Matern/RBF or multi-output or Sum. It doesn't support mixing muti-output with combination kernels for instance; that would get complex if we start considering cases where only some of the latent-kernels are a combination etc.
In the combination (i.e. Sum) kernel case, the number of feature is multiplied by the number of sub-kernels. I tried to keep them as a separate dimension (first one), as in the multi-output case, but that doesn't work well with trieste/gpflow. The main reason being that normal kernels and multi-output kernels behave slightly differently in gpflow, and adding an extra dimension to the covariance matrix causes issues in the normal kernel case. So for this gpflux PR, the dimension is kept separate in most places, but when the features are returned in
call
, it is flattened into the last (features) dimension.The generalisation of the batching may be useful for any future combination kernels and batching functionality we add support for.