Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom cook cycles and Binary_Sensors #40

Closed
wants to merge 23 commits into from

Conversation

njobrien1006
Copy link
Contributor

@njobrien1006 njobrien1006 commented Apr 8, 2022

Also seems to have open pull request #38 in here.

B.Sensor

  • Add Binary_Sensor.py and add calls to add on init.
  • Add translations for Binary_Sensor.

Numbers = CookCycle

  • Add to numbers.py the cook_cycle entity.
  • Embed the service.yaml.
  • Other Cleanup/UIpdates.

Pull Request in relation to Feature Request #39

-Finish out Paho Capabilities.
-ReWork how Paho is being called synchronously vs the main in async

-Fix Grill Disconnect indicator.
-Add AutoDisconnect
-Ensure grill reports unavailable when switch.connect is off.
Removed per Cron Action failed error.
#Wrong one.
I guess it doesn't want either title.
Nesting Error and remove comment lines.
Add Binary Sensor for:
-CookTimerComplete
-ProbeAlarmFired
STR() instead of object so it is accessible from the UI.
@sebirdman
Copy link
Owner

@njobrien1006 this looks good! i merged the first MR and will merge this once the conflicts are resolved.

Remove unneeded comment to resolve conflict
@njobrien1006
Copy link
Contributor Author

@sebirdman should be resolved and ready.

@sebirdman
Copy link
Owner

@njobrien1006 looks like this still can't be rebased on github.

i've merged #42 as well. some of this looks like it's a little overlapping (the probe sensor stuff on 42 looks to be pretty complete. but your work on the timer side still looks good to go.

@njobrien1006
Copy link
Contributor Author

@sebirdman Rebased, Squashed, Re-PR'd #43

I had put the Probe in there for testing when working with stephenpapierski prior to that PR. Can certainly take it out.

@njobrien1006 njobrien1006 deleted the custom_cook_cycles branch May 20, 2023 03:39
tmack8001 pushed a commit to tmack8001/hass_traeger that referenced this pull request Jan 8, 2024
* autoyapf

* Automated autoyapf fixes

* V.Updt

* VersUpdt

* LintChange

---------

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants