Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17 pragma based router #19

Merged
merged 9 commits into from
Mar 3, 2024
Merged

17 pragma based router #19

merged 9 commits into from
Mar 3, 2024

Conversation

sebastianconcept
Copy link
Owner

The builder now generates the methods that defines routes in the presenters' class side.

Feels quite comfortable and makes the a CRUD fully usable by default just after being created without any additional change.

Copy link
Collaborator

@paulwilke paulwilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the PR and wanted to drop some quick thoughts. First off, love the router revamp and the use of pragma for routing – neat and flexible without being bloated.

The handling of dev vs. production environments is a smart move for maintainability. Might be worth adding a few comments or brief docs for clarity, especially for us not knee-deep in the details.

Lastly, while the optimizations and refactoring are top-notch, keeping an eye on test coverage would be cool, just to ensure no unintended breakages sneak through

@sebastianconcept
Copy link
Owner Author

Thank you for taking a look @paulwilke ! I've added this one to have a reminder on having a how-to for deploys
#21

And for detecting regressions and gaining trust improve that coverage is a must. Seeing that 1% is painful 🔥 but it can start with the router. I push a commit for that to break the ice on this.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 18.96552% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 4.93%. Comparing base (78cff44) to head (51376ac).

Files Patch % Lines
Ride/RideServer.class.st 32.35% 23 Missing ⚠️
Ride/RideResource.class.st 0.00% 16 Missing ⚠️
Ride/Ride.class.st 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master     #19      +/-   ##
=========================================
+ Coverage    0.71%   4.93%   +4.21%     
=========================================
  Files          25      25              
  Lines        3070    3123      +53     
=========================================
+ Hits           22     154     +132     
+ Misses       3048    2969      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianconcept sebastianconcept merged commit 0ecc6cd into master Mar 3, 2024
4 checks passed
@sebastianconcept sebastianconcept deleted the 17-Pragma-based-router branch March 3, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants