adds coverage with testTryingToAddAnAlreadyDefinedRoute

Ride-Tests/RideDeclarativeRoutingTest.class.st

@@ -16,3 +16,26 @@ RideDeclarativeRoutingTest >> testSimpleWithoutParameters [
 	self assert: response equals: 'CoffeInvoice1'.
 	server stop
 ]
+
+{ #category : #tests }
+RideDeclarativeRoutingTest >> testTryingToAddAnAlreadyDefinedRoute [
+
+	| server routes |
+	routes := OrderedCollection new.
+	server := RideServer new.
+
+	self
+		shouldnt: [
+		server addRouteDefinition: { (#PATCH -> '/posts/<id>') } to: routes ]
+		raise: RideAlreadyDefinedRouteError.
+
+	self
+		shouldnt: [
+		server addRouteDefinition: { (#GET -> '/posts/<id>') } to: routes ]
+		raise: RideAlreadyDefinedRouteError.
+
+	self
+		should: [
+		server addRouteDefinition: { (#PATCH -> '/posts/<id>') } to: routes ]
+		raise: RideAlreadyDefinedRouteError
+]

Ride/RideAlreadyDefinedRouteError.class.st

@@ -0,0 +1,8 @@
+"
+Signal that a route is already set
+"
+Class {
+	#name : #RideAlreadyDefinedRouteError,
+	#superclass : #RideError,
+	#category : #'Ride-Exceptions'
+}

Ride/RideServer.class.st

@@ -185,6 +185,19 @@ RideServer class >> webSockerPort [
 		   ifAbsent: [ self defaultWebSocketPort ]) asInteger
 ]
 
+{ #category : #accessing }
+RideServer >> addRouteDefinition: routeDefinition to: someRouteDefinitions [
+	"Adds the given route to someRouteDefinitions."
+
+	"Signal an exception if the route is already defined."
+
+	(someRouteDefinitions anySatisfy: [ :each |
+		 each first = routeDefinition first ]) ifTrue: [
+		RideAlreadyDefinedRouteError signal: self asString ].
+
+	someRouteDefinitions add: routeDefinition
+]
+
 { #category : #accessing }
 RideServer >> debugMode [
 
@@ -355,9 +368,12 @@ RideServer >> routesDeclaration [
 	all := OrderedCollection new.
 
 	(self routesDeclarationFromPragma: #rideRoutes) do: [
-		:routeDefinitions | all addAll: routeDefinitions ].
+		:routeDefinitions |
+		routeDefinitions do: [ :routeDefinition |
+			self addRouteDefinition: routeDefinition to: all ] ].
 
-	all addAll: (self routesDeclarationFromPragma: #rideRoute).
+	(self routesDeclarationFromPragma: #rideRoute) do: [ :routeDefinition |
+		self addRouteDefinition: routeDefinition to: all ].
 
 	^ all
 ]