remove remaining deprecations

sebastianconcept · Feb 25, 2024 · 35b6060 · 35b6060
1 parent 8e54ef3
commit 35b6060
Show file tree

Hide file tree

Showing 14 changed files with 22 additions and 422 deletions.
diff --git a/Ride-Builder/RideAppClassHelper.class.st b/Ride-Builder/RideAppClassHelper.class.st
@@ -46,17 +46,6 @@ RideAppClassHelper class >> installMethodFor: aSymbol [
 	Ride service maitre: {1}Maitre new' format: { aSymbol }
 ]
 
-{ #category : #accessing }
-RideAppClassHelper class >> newSessionWith_UrlMethodFor: aSymbol [
-
-	^ 'newSessionWith: sessionId url: anUrl
-	
-	"Answer a new {1}App session with the given sessionId and url."
-
-	^ self sessionClass newWith: sessionId url: anUrl
-' format: { aSymbol }
-]
-
 { #category : #accessing }
 RideAppClassHelper class >> sessionClassMethodFor: aSymbol [
 

diff --git a/Ride-Builder/RideCRUDHelper.class.st b/Ride-Builder/RideCRUDHelper.class.st
@@ -172,32 +172,6 @@ RideCRUDHelper >> addAllowedParamsMethodTo: aClass for: aSymbol [
 	aClass organization classify: #allowedParams under: 'accessing'	
 ]
 
-{ #category : #actions }
-RideCRUDHelper >> addCRUDMethodsTo: aClass for: aSymbol [
-self deprecated: 'singular or plural'.
-	self addIndexMethodTo: aClass for: aSymbol.
-	self addModelsAccessorMethodTo: aClass for: aSymbol.
-	self addShowMethodTo: aClass for: aSymbol.
-	self addNewModelMethodTo: aClass for: aSymbol.
-	self addEditMethodTo: aClass for: aSymbol.
-	self addCreateMethodTo: aClass for: aSymbol.
-	self addUpdateMethodTo: aClass for: aSymbol.
-	self addDestroyMethodTo: aClass for: aSymbol
-]
-
-{ #category : #actions }
-RideCRUDHelper >> addCRUDTemplatesTo: aClass for: aSymbol [
-self deprecated: 'silgular or plural'.
-	self addIndexTemplateFor: aSymbol.
-	self addShowTemplateFor: aSymbol.
-	self addNewTemplateFor: aSymbol.
-	self addEditTemplateFor: aSymbol.
-	self addFormNewTemplateFor: aSymbol.
-	self addFormEditTemplateFor: aSymbol.
-	self addFormFieldsTemplateFor: aSymbol.
-	self addModelDisplayContentFor: aSymbol
-]
-
 { #category : #actions }
 RideCRUDHelper >> addCreateMethodTo: aClass for: aSymbol [
 
@@ -243,26 +217,6 @@ RideCRUDHelper >> addFormNewTemplateFor: aSymbol [
 	self subclassResponsibility
 ]
 
-{ #category : #actions }
-RideCRUDHelper >> addFormTemplateFor: aSymbol [
-
-	self deprecated: 'use either formNew or formEdit'.
-	self subclassResponsibility
-]
-
-{ #category : #actions }
-RideCRUDHelper >> addIndexMethodTo: aClass for: aSymbol [
-	self deprecated: ' plural or singular'.
-	aClass compile: (self class indexMethodFor: aSymbol).
-	aClass organization classify: #index under: 'actions'	
-]
-
-{ #category : #actions }
-RideCRUDHelper >> addIndexTemplateFor: aSymbol [
-
-	self subclassResponsibility
-]
-
 { #category : #actions }
 RideCRUDHelper >> addModelDisplayContentFor: aSymbol [
 
@@ -349,19 +303,6 @@ RideCRUDHelper >> addPluralModelDisplayContentFor: aSymbol [
 	self subclassResponsibility
 ]
 
-{ #category : #actions }
-RideCRUDHelper >> addShowMethodTo: aClass for: aSymbol [
-self deprecated: 'no'.
-	aClass compile: (self class singularIndexMethodFor: aSymbol).
-	aClass organization classify: #index under: 'actions'	
-]
-
-{ #category : #actions }
-RideCRUDHelper >> addShowTemplateFor: aSymbol [
-self deprecated: 'no'.
-	self subclassResponsibility
-]
-
 { #category : #actions }
 RideCRUDHelper >> addSingularCRUDMethodsTo: aClass for: aSymbol [
 

diff --git a/Ride-Builder/RideMVPCRUDHelper.class.st b/Ride-Builder/RideMVPCRUDHelper.class.st
@@ -39,14 +39,6 @@ RideMVPCRUDHelper >> addFormNewTemplateFor: aSymbol [
 		crudFormNewFor: aSymbol
 ]
 
-{ #category : #adding }
-RideMVPCRUDHelper >> addIndexTemplateFor: aSymbol [
-self deprecated: 'singular or plural'.
-	builder view stt
-		js: js;
-		crudIndexFor: aSymbol
-]
-
 { #category : #adding }
 RideMVPCRUDHelper >> addModelDisplayContentFor: aSymbol [
 
@@ -79,14 +71,6 @@ RideMVPCRUDHelper >> addPluralModelDisplayContentFor: aSymbol [
 		crudPluralModelDisplayContentFor: aSymbol 
 ]
 
-{ #category : #adding }
-RideMVPCRUDHelper >> addShowTemplateFor: aSymbol [
-
-	builder view stt
-		js: js;
-		crudShowFor: aSymbol
-]
-
 { #category : #adding }
 RideMVPCRUDHelper >> addSingularIndexTemplateFor: aSymbol [
 

diff --git a/Ride-Builder/RideSTTemplateHelper.class.st b/Ride-Builder/RideSTTemplateHelper.class.st
@@ -179,37 +179,6 @@ RideSTTemplateHelper class >> pluralIndexContentFor: aSymbol [
 			  aSymbol uncapitalized asSingular }
 ]
 
-{ #category : #accessing }
-RideSTTemplateHelper class >> showContentFor: aSymbol [
-self deprecated: 'no used anymore'.
-	^ '<%= self render: self using: ''shared/feedback.html'' %>
-<div class="container">
-	<h1>{1}</h1>
-	<%= self render: model %>
-	<div>
-		<ul>
-			<li>
-				<a href="/{4}/<%= model id %>/edit">Edit this {3}</a>
-			</li>
-			<li>
-				<form action="/{4}/<%= model id%>" method="POST">
-					<input type="hidden" name="_method" value="DELETE" autocomplete="off">
-					<input type="hidden" name="authenticity_token" value="<%= self newAuthToken %>" autocomplete="off">
-					<button type="submit">Delete this {3}</button>
-				</form>
-			</li>
-		</ul>
-	</div>
-	<a href="/{4}">Back to {2}</a>
-</div>
-' format: { 
-			  aSymbol.
-			  aSymbol asPlural uncapitalized.
-			  aSymbol uncapitalized.
-			  aSymbol asPlural asSnakeCase.
-			  aSymbol asPlural }
-]
-
 { #category : #actions }
 RideSTTemplateHelper >> crudEditFor: aSymbol [
 
@@ -326,18 +295,6 @@ RideSTTemplateHelper >> crudPluralModelDisplayContentFor: aSymbol [
 		contents: (self class modelDisplayContentFor: aSymbol)
 ]
 
-{ #category : #actions }
-RideSTTemplateHelper >> crudShowFor: aSymbol [
-
-	"Creates the template file for the view showing many models named aSymbol.
-	Find it as show.html.stt"
-
-	self
-		template: #show
-		for: aSymbol
-		contents: (self class showContentFor: aSymbol)
-]
-
 { #category : #'instance creation' }
 RideSTTemplateHelper >> for: aSymbol [
 

diff --git a/Ride/RideDirectoryResolver.class.st b/Ride/RideDirectoryResolver.class.st
diff --git a/Ride/RideMaitre.class.st b/Ride/RideMaitre.class.st
@@ -12,17 +12,6 @@ Class {
 	#category : #'Ride-Core'
 }
 
-{ #category : #accessing }
-RideMaitre class >> assetsDirectory [
-
-	self deprecated: 'use locator'.
-	self halt.
-	^ (Smalltalk os environment
-		   at: 'ASSETS_PATH'
-		   ifAbsent: [ Smalltalk imageDirectory / 'app' / 'assets' ])
-		  asFileReference
-]
-
 { #category : #accessing }
 RideMaitre class >> workersPoolSize [
 

diff --git a/Ride/RideMaplessModel.class.st b/Ride/RideMaplessModel.class.st
@@ -6,15 +6,3 @@ Class {
 	#superclass : #Mapless,
 	#category : #'Ride-Models'
 }
-
-{ #category : #converting }
-RideMaplessModel >> asMustacheTemplateModel [
-	self deprecated: 'use asTemplateModel'.
-	^ { (#name -> self class name) } asDictionary
-]
-
-{ #category : #converting }
-RideMaplessModel >> asTemplateModel [
-
-	^ { (#name -> self class name) } asDictionary
-]
diff --git a/Ride/RideModel.class.st b/Ride/RideModel.class.st
@@ -13,19 +13,6 @@ RideModel class >> getRepository [
 	^ Ride service repository
 ]
 
-{ #category : #converting }
-RideModel >> asMustacheTemplateModel [
-
-	self deprecated: 'use asTemplateModel'.
-	^ { (#name -> self class name) } asDictionary
-]
-
-{ #category : #converting }
-RideModel >> asTemplateModel [
-
-	^ { (#name -> self class name) } asDictionary
-]
-
 { #category : #'as yet unclassified' }
 RideModel >> destroyOrSignal [
 

diff --git a/Ride/RideMustacheRenderer.class.st b/Ride/RideMustacheRenderer.class.st
@@ -50,7 +50,7 @@ RideMustacheRenderer >> render: aTemplateName in: aLayoutNameOrNil for: aRidePre
 
 	"Render the template found with aTemplateName embedded 
 	in the layout at aLayoutNameOrNil for aRidePresenter."
-
+	self flag: #review.
 	^ self
 		  render: aRidePresenter mustacheTemplateModel
 		  using: aTemplateName
@@ -134,7 +134,7 @@ RideMustacheRenderer >> render: aTemplateContext using: aTemplateName in: aLayou
 RideMustacheRenderer >> renderUsing: aTemplateName for: aRidePresenter [
 
 	"Render the template found with aTemplateName for aRidePresenter."
-
+	self flag: #review.
 	^ self
 		  render: aRidePresenter mustacheTemplateModel
 		  using: aTemplateName

diff --git a/Ride/RidePresenter.class.st b/Ride/RidePresenter.class.st
@@ -26,14 +26,6 @@ Class {
 	#category : #'Ride-Presenters'
 }
 
-{ #category : #accessing }
-RidePresenter class >> basePath [
-
-	"Answers the view name of this presenter as snake case."
-	self deprecated: 'not in use'.
-	^ self getModelName asSnakeCase
-]
-
 { #category : #accessing }
 RidePresenter class >> defaultModel [
 
@@ -384,29 +376,6 @@ RidePresenter >> modelNotFoundHandler [
 				   id asString }) ]
 ]
 
-{ #category : #accessing }
-RidePresenter >> mustacheTemplateModel [
-
-	"Answers the model used for the template that 
-	will render only the HTML of this component (not the full page)."
-
-	| template presenterJsAssets |
-
-	template := model asMustacheTemplateModel.
-	presenterJsAssets := Ride resource assetsMap js
-		                     at: self class getNormalizedModelName
-		                     ifAbsent: [ nil ].
-
-	^ (presenterJsAssets notNil and: [ presenterJsAssets notEmpty ])
-		  ifFalse: [ template ]
-		  ifTrue: [ 
-			  presenterJsAssets keysAndValuesDo: [ :key :value | 
-				  template
-					  at: ('{1}Js' format: { key })
-					  put: ('/assets/js/{1}' format: { value }) ].
-			  template ]
-]
-
 { #category : #actions }
 RidePresenter >> newAuthToken [