-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed MCMC for multiple visits, applied "uncmulti_val" to error, added model "model_rowshift" #28
base: master
Are you sure you want to change the base?
fixed MCMC for multiple visits, applied "uncmulti_val" to error, added model "model_rowshift" #28
Conversation
Hi @K-Angelique-Kahle |
Hi @sebastian-zieba |
MCMC for multiple visits (applied these changes also for nested sampling, but may not be sufficient to fix nested):
Files: mcmc , nested , util
What? util.format_params_for_Model now alters the parameters of all visits in updated_params. Therefore, model.fit now considers all visits.
applied uncmulti_val to error
Files: mcmc, nested
What? uncmulti_val was previously only applied during sampling, but the final uncmulti_val was not applied on the errors. It is now.
added model model_rowshift
Files: fit_par, obs_par, plots, formatter, functions, model_rowshift (new), read_data, util, s20_extract
What? Added new systematics model that may be needed for fast scans of bright stars. In s20_extract, it measures the vertical (rows) position of the spectrum of all exposures (based on the first non-destructive exposure) with respect to the spectrum-position of the first exposure in the data (rowshift). This rowshift is stored in meta and some diagnostics plots can be saved if needed. In s30, the new function "model_rowshift" fits linear slopes as a function of rowshift to the forward and reverse scans in the data.
I tried to leave the runtime of PACMAN mostly unchanged if the function is not used.