-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Small Fixes 1/10 #690
Fix: Small Fixes 1/10 #690
Conversation
e3732ee
to
a4c0980
Compare
.Where(x => partyPawns.Contains(x)) | ||
.Select((pawn, index) => new CDataPawnJobChangeInfo() | ||
{ | ||
SlotNo = (byte)(index + 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The index is done after the filtering, so if you got 3 pawns, A, B and C and only two of them, A and C in the party, they would be reported as slots 1 and 2 when they should be slots 1 and 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually expecting the order in the party, which is the order used by the UI. If you have three pawns A/B/C, but have them in the party A/C/B, you should report them in the order with indices A-1/C-2/B-3.
…t the packet size limit.
…ptions; Revert InstanceGetGatheringItemHandler so it stops breaking other things.
…er codes to the player.
…ndler to use a transaction.
a4c0980
to
672bae6
Compare
Weekly PR for various bugfixes as they're reported.
Checklist:
develop
branch