Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Small Fixes 1/10 #690

Merged
merged 11 commits into from
Jan 17, 2025

Conversation

RyanYappert
Copy link
Collaborator

@RyanYappert RyanYappert commented Jan 11, 2025

Weekly PR for various bugfixes as they're reported.

  • Prevent JobGetJobChangeListHandler from hitting the packet size limit by removing unneeded information from the packet.
  • Stop ItemConsumeStorageItemHandler from squelching errors.
  • Fix the underlying issue with the above, which was BBM "Equip from Chest" still being broken. We're reverting back to before I tried to optimize it and broke it.
  • More tweaks to server info tracking to prevent it from reading 0s for player counts when under pressure.
  • Prevent NRE when running in NaiveLobbyHandling mode.
  • Better exceptions for ItemManager.
  • Fix bad constructor for C2SCraftGetCraftProductRes that was breaking error handling (when trying to collect a finished craft with a full storage box or bag).

Checklist:

  • The project compiles
  • The PR targets develop branch

@RyanYappert RyanYappert force-pushed the fix/small-fixes-1-10 branch 2 times, most recently from e3732ee to a4c0980 Compare January 14, 2025 23:13
@RyanYappert RyanYappert marked this pull request as ready for review January 14, 2025 23:14
.Where(x => partyPawns.Contains(x))
.Select((pawn, index) => new CDataPawnJobChangeInfo()
{
SlotNo = (byte)(index + 1),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index is done after the filtering, so if you got 3 pawns, A, B and C and only two of them, A and C in the party, they would be reported as slots 1 and 2 when they should be slots 1 and 3

Copy link
Collaborator Author

@RyanYappert RyanYappert Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually expecting the order in the party, which is the order used by the UI. If you have three pawns A/B/C, but have them in the party A/C/B, you should report them in the order with indices A-1/C-2/B-3.

@RyanYappert RyanYappert merged commit 64a5374 into sebastian-heinz:develop Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants