Make asyncore support optional for Python 3. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
13 tasks
sarcasticadmin
added a commit
to sarcasticadmin/nixpkgs
that referenced
this pull request
Jul 9, 2024
asyncore was removed from the python 3.12 standard library: https://peps.python.org/pep-0594/ This patch was original sourced from: seb-m/pyinotify#205
sarcasticadmin
added a commit
to sarcasticadmin/nixpkgs
that referenced
this pull request
Jul 9, 2024
asyncore was removed from the python 3.12 standard library: https://peps.python.org/pep-0594/ This patch was original sourced from: seb-m/pyinotify#205
github-actions bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Jul 15, 2024
asyncore was removed from the python 3.12 standard library: https://peps.python.org/pep-0594/ This patch was original sourced from: seb-m/pyinotify#205 (cherry picked from commit 7ea81e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for Python 3.12 since it dropped asyncore. Catches the import error instead of using a version check so that the user can install the compatibility package for any uses that can't be upgraded to asyncio or similar immediately.
Fixes #204.