Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod] remove non SearXNG instances (the old searx instances) from the list #331

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

return42
Copy link
Member

@return42 return42 commented May 6, 2023

  1. remove old / unmaintained instances from the list
  2. remove support of searx from the issue templates

Closes: #330

@unixfox
Copy link
Member

unixfox commented May 6, 2023

Like we have discussed internally in the past, I do not want to remove them before giving a very long warning to all the programs that are using the searx.space API.

@unixfox
Copy link
Member

unixfox commented Jun 3, 2023

Could you rebase your PR? I did remove one SearX instance here: 45d4fbb

@return42 return42 force-pushed the rm-searx-instances branch from 57c687c to 296eaee Compare June 3, 2023 15:02
@return42
Copy link
Member Author

return42 commented Jun 3, 2023

Could you rebase your PR? I did remove one Sear

Thanks for pointing out .. done.

@unixfox
Copy link
Member

unixfox commented Jul 19, 2023

This need a double check because some instances are not "searx" anymore and switched to searxng.

@unixfox
Copy link
Member

unixfox commented Aug 29, 2023

List of instances that have switched to SearXNG:

By the way, some in the list were removed due to bad uptime or down or doesn't serve searx anymore.

Copy link
Member

@unixfox unixfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instance to remove from the list too: https://searx.fossencdi.org

@return42 return42 force-pushed the rm-searx-instances branch from 296eaee to 16df460 Compare August 31, 2023 17:32
@return42
Copy link
Member Author

List of instances that have switched to SearXNG:

I vote to remove suche.tromdienste.de and search.trom.tf .. both are not vanilla (IDK what state they have) --> "Remove instances that have broken functionalities or broken resources (CSS or/and JS). Like instances that return no results by default, example: https://nibblehole.com/ (I'm removing it). Or instances with broken CSS and JS resources: https://suche.tromdienste.de/ and https://search.trom.tf/"

I vote to remove: IIRC comes from a old searx list --> we do not have ticket -> declaration of conformity is not available for this instance

Yeah updated 👍

By the way, some in the list were removed due to bad uptime or down or doesn't serve searx anymore.

Cleaned up in line with a git re-base :)

@return42 return42 requested a review from unixfox August 31, 2023 17:32
@dalf
Copy link
Member

dalf commented Aug 31, 2023

I vote to remove: IIRC comes from a old searx list --> we do not have ticket -> declaration of conformity is not available for this instance

searx/searx-instances#119

Not the last form, but I guess as many other instances (?).

@return42
Copy link
Member Author

return42 commented Sep 1, 2023

Not the last form, but I guess as many other instances (?).

Oops .. I mixed with other instance 👍 / fixed --> diff

@unixfox
Copy link
Member

unixfox commented Sep 1, 2023

List of instances that have switched to SearXNG:

I vote to remove suche.tromdienste.de and search.trom.tf .. both are not vanilla (IDK what state they have) --> "Remove instances that have broken functionalities or broken resources (CSS or/and JS). Like instances that return no results by default, example: https://nibblehole.com/ (I'm removing it). Or instances with broken CSS and JS resources: https://suche.tromdienste.de/ and https://search.trom.tf/"

When searching on them, both works and returns results. If we want to remove instances like we have always done, we should remove based on the rules.

If we want to remove these instances, we must create a rule that state out of date instances can't be kept in the list, this includes unknown versions which probably indicate an out of date instance.

So until we have such a rule, both of these instances qualify for staying in the list.

@return42
Copy link
Member Author

return42 commented Sep 1, 2023

https://search.trom.tf/ is broken and we do not have an issue entry --> we can't contact the maintainer:

image

same with https://suche.tromdienste.de/ .. we should not recommend broken instances at searx.space I think.

@return42 return42 mentioned this pull request Sep 1, 2023
2 tasks
@tio-trom
Copy link

tio-trom commented Sep 1, 2023

https://search.trom.tf/ is broken and we do not have an issue entry --> we can't contact the maintainer:

I am the maintainer. What is broken about it? We use it daily.

@aarontrom
Copy link

aarontrom commented Sep 1, 2023

same with https://suche.tromdienste.de/ .. we should not recommend broken instances at searx.space I think.

are you sure, these are broken?

For me both instances are working. Tested from different browsers.

@return42
Copy link
Member Author

return42 commented Sep 1, 2023

Look at the screenshot, you modified the instances to include CSS an JS but the urls can't be loaded --> for what are these CSS and JS injection are intended?

@tio-trom
Copy link

tio-trom commented Sep 1, 2023

Look at the screenshot, you modified the instances to include CSS an JS but the urls can't be loaded --> for what are these CSS and JS injection are intended?

These are Yunohost packages https://github.com/YunoHost-Apps/searxng_ynh they add those CSS and JS for all of their packages to allow admins to have a way to go back to the Yunohost panel quickly.

EDIT: Also I keep my instance very up to date, only now when I had to travel for a week I was unable to update it but it is still at version 2023.08.06.14.39.00

@return42
Copy link
Member Author

return42 commented Sep 1, 2023

EDIT: Also I keep my instance very up to date, only now when I had to travel for a week I was unable to update it but it is still at version 2023.08.06.14.39.00

@tio-trom: Why did your customization hides this info from the users?

@aarontrom: you instance show wrong version info to the user

these are Yunohost packages https://github.com/YunoHost-Apps/searxng_ynh

But its broken .. why not removing or fix broken stuff?

@unixfox
Copy link
Member

unixfox commented Sep 1, 2023

search.trom.tf is broken and we do not have an issue entry --> we can't contact the maintainer:
same with suche.tromdienste.de .. we should not recommend broken instances at searx.space I think.

Missing CSS resource != broken instance

If the instance still works fine, with the current rules, I see no objection in removing them.

If there are additional CSS or JS resources, the instance will be ranked lower as such, that's it.

@tio-trom
Copy link

tio-trom commented Sep 1, 2023

@tio-trom: Why did your customization hides this info from the users?

No special reason, more than having it more clean and user friendly. I can add it back if that's an issue.

But its broken .. why not removing or fix broken stuff?

I am not sure why these resources do not load sometime. This must be a YNH issue.

EDIT: I added the footer back and I will leave it there from now on.

@unixfox
Copy link
Member

unixfox commented Sep 1, 2023

Anyway, I'm not against adding rules for removing such instances. But like I said, we do not remove instances based on personal opinion.

… list

1. remove old / unmaintained instances from the list
2. remove support of searx from the issue templates

Closes: searxng#330
Signed-off-by: Markus Heiser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete non SearXNG instances
5 participants