Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkbox a11y #1169

Merged
merged 3 commits into from
Sep 24, 2024
Merged

checkbox a11y #1169

merged 3 commits into from
Sep 24, 2024

Conversation

chrisFrazier77
Copy link
Contributor

No description provided.

@chrisFrazier77 chrisFrazier77 marked this pull request as ready for review September 24, 2024 15:25
korgon
korgon requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needs adjusting - we should assert that this new attribute exists or doesn't exist depending on the state.

korgon
korgon requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test assertion to verify that the checked state properly adjusts the aria-checked attribute?

korgon
korgon approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@korgon korgon merged commit 0721bfc into develop Sep 24, 2024
1 check passed
@korgon korgon deleted the checkbox-a11y branch September 24, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korgon korgon korgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisFrazier77 @korgon