Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker Trimmin #1167

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Tracker Trimmin #1167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/snap-tracker/src/Tracker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ export class Tracker {
const sku = data?.childSku || data?.childUid || data?.sku || data?.uid;
if (sku) {
const lastViewedProducts = this.cookies.viewed.get();
const uniqueCartItems = Array.from(new Set([...lastViewedProducts, sku])).map((item) => item.trim());
const uniqueCartItems = Array.from(new Set([...lastViewedProducts, sku])).map((item) => `${item}`.trim());
cookies.set(
VIEWED_PRODUCTS,
uniqueCartItems.slice(0, MAX_VIEWED_COUNT).join(','),
Expand Down Expand Up @@ -688,7 +688,7 @@ export class Tracker {
},
set: (items: string[]): void => {
if (items.length) {
const cartItems = items.map((item) => item.trim());
const cartItems = items.map((item) => `${item}`.trim());
const uniqueCartItems = Array.from(new Set(cartItems));
cookies.set(CART_PRODUCTS, uniqueCartItems.join(','), COOKIE_SAMESITE, 0, COOKIE_DOMAIN);

Expand All @@ -701,7 +701,7 @@ export class Tracker {
add: (items: string[]): void => {
if (items.length) {
const currentCartItems = this.cookies.cart.get();
const itemsToAdd = items.map((item) => item.trim());
const itemsToAdd = items.map((item) => `${item}`.trim());
const uniqueCartItems = Array.from(new Set([...currentCartItems, ...itemsToAdd]));
cookies.set(CART_PRODUCTS, uniqueCartItems.join(','), COOKIE_SAMESITE, 0, COOKIE_DOMAIN);

Expand All @@ -714,7 +714,7 @@ export class Tracker {
remove: (items: string[]): void => {
if (items.length) {
const currentCartItems = this.cookies.cart.get();
const itemsToRemove = items.map((item) => item.trim());
const itemsToRemove = items.map((item) => `${item}`.trim());
const updatedItems = currentCartItems.filter((item) => !itemsToRemove.includes(item));
cookies.set(CART_PRODUCTS, updatedItems.join(','), COOKIE_SAMESITE, 0, COOKIE_DOMAIN);

Expand Down
Loading