Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates Improvements #1144

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Templates Improvements #1144

merged 1 commit into from
Sep 3, 2024

Conversation

korgon
Copy link
Contributor

@korgon korgon commented Aug 31, 2024

  • adjusted deepmerge functionality when used in ThemeStore - it wasn't actually doing the arrayMerge at all
  • refactored arrayMerge function so that certain array merges behave as we expect
  • added many more tests to ensure the deepmerge changes are thoroughly tested
  • refactored the Theme and ThemeVaraible types to remove Partial<> and DeepPartial<> in an effort to prevent misuse in the TemplateConfig
  • adjusting 'grid' / 'list' typing for Result and Results components

@korgon korgon merged commit e01405e into templates Sep 3, 2024
1 check passed
@korgon korgon deleted the templates-theme-improvements branch September 3, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkonieczek dkonieczek dkonieczek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korgon @dkonieczek