feat: add onTarget to template recommendations config #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korgon
reviewed
Aug 21, 2024
Comment on lines
85
to
99
| 'recommendation.bundle': { | ||
| RecommendationBundle: async () => { | ||
| return ( | ||
| this.components.recommendation.Recommendation || | ||
| (this.components.recommendation.Recommendation = (await import('./library/components/Recommendation')).Recommendation) | ||
| this.components['recommendation.bundle'].RecommendationBundle || | ||
| (this.components['recommendation.bundle'].RecommendationBundle = ( | ||
| await import('./library/components/RecommendationBundle') | ||
| ).RecommendationBundle) | ||
| ); | ||
| }, | ||
| RecommendationBundle: async () => { | ||
| }, | ||
| 'recommendation.default': { | ||
| Recommendation: async () => { | ||
| return ( | ||
| this.components.recommendation.RecommendationBundle || | ||
| (this.components.recommendation.RecommendationBundle = (await import('./library/components/RecommendationBundle')).RecommendationBundle) | ||
| this.components['recommendation.default'].Recommendation || | ||
| (this.components['recommendation.default'].Recommendation = (await import('./library/components/Recommendation')).Recommendation) |
There was a problem hiding this comment.
Is there any reason to not actually go another level deeper in the object instead of using a . to delimit the path superficially?
There was a problem hiding this comment.
No particular reason. I think I'd actually prefer a / instead of . since we don't do this else where. Nested object would also work
There was a problem hiding this comment.
Unless there is good reason, I think my preference here is nested object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.