Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracker): add currency context, add transactionTotal to order tr… #1078

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

dkonieczek
Copy link
Contributor

…ansaction payload

@dkonieczek dkonieczek requested a review from korgon June 20, 2024 16:35
@dkonieczek dkonieczek linked an issue Jun 20, 2024 that may be closed by this pull request
chrisFrazier77
chrisFrazier77 previously approved these changes Jun 20, 2024
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested in review, but additionally, there should be a way to set the currency via the script context variables (similar to shopperId).

Perhaps something like this:

<script src="https://snapui.searchspring.io/[your_site_id]/bundle.js">
    currency = { code: "USD" };
</script>

docs/INTEGRATION_TRACKING.md Show resolved Hide resolved
packages/snap-tracker/README.md Show resolved Hide resolved
packages/snap-tracker/README.md Outdated Show resolved Hide resolved
packages/snap-tracker/README.md Outdated Show resolved Hide resolved
packages/snap-tracker/README.md Outdated Show resolved Hide resolved
packages/snap-tracker/src/PixelEvent.ts Outdated Show resolved Hide resolved
packages/snap-tracker/src/Tracker.ts Outdated Show resolved Hide resolved
packages/snap-tracker/src/Tracker.ts Outdated Show resolved Hide resolved
packages/snap-tracker/src/Tracker.ts Outdated Show resolved Hide resolved
packages/snap-tracker/src/Tracker.ts Outdated Show resolved Hide resolved
packages/snap-tracker/src/Tracker.ts Outdated Show resolved Hide resolved
packages/snap-preact/src/Snap.tsx Outdated Show resolved Hide resolved
packages/snap-tracker/src/Tracker.ts Outdated Show resolved Hide resolved
@dkonieczek dkonieczek requested a review from korgon June 26, 2024 15:56
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@korgon korgon merged commit 3cc0c5d into develop Jun 26, 2024
1 check passed
@korgon korgon deleted the currency-context branch June 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add currency context and transactionTotal
3 participants