Merge pull request #17 from seantcanavan/fix_unset_issue

fix issue where unset strings would attempt to cause a conversion to a mongodb id
seantcanavan · Jan 2, 2024 · ab0d1a6 · ab0d1a6
2 parents 78ca3cd + b1c5bea
commit ab0d1a6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lambda_router/decoder.go b/lambda_router/decoder.go
@@ -182,7 +182,8 @@ func unmarshalField(
 	strVal, ok := params[param]
 	strVals, okMulti := multiParam[param]
 
-	if !ok && !okMulti {
+	// check for empty / unset values and return no error if so
+	if !ok && !okMulti || (strVal == "" && strVals == nil) {
 		return nil
 	}
 

diff --git a/lambda_router/decoder_test.go b/lambda_router/decoder_test.go
@@ -222,6 +222,19 @@ func Test_UnmarshalReq(t *testing.T) {
 		)
 		require.NoError(t, err)
 	})
+	t.Run("valid input unset values", func(t *testing.T) {
+		var input mockListReq
+		err := UnmarshalReq(
+			events.APIGatewayProxyRequest{
+				QueryStringParameters: map[string]string{
+					"mongoId": "",
+				},
+			},
+			false,
+			&input,
+		)
+		require.NoError(t, err)
+	})
 
 	t.Run("invalid path&query input", func(t *testing.T) {
 		var input mockListReq