Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle recursive and cyclic TypeAliasType #8

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

seandstewart
Copy link
Owner

  • Fixes an issue where a direct recursive or indirect reference to a TypeAliasType would produce an unusable type-hint and fail to resolve the forward reference.

- Fixes an issue where a direct recursive or indirect reference to a `TypeAliasType` would produce an unusable type-hint and fail to resolve the forward reference.
@seandstewart seandstewart self-assigned this Oct 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.26%. Comparing base (af876cc) to head (94c8fa3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/typelib/py/inspection.py 60.00% 3 Missing and 1 partial ⚠️
src/typelib/graph.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   96.50%   96.26%   -0.25%     
==========================================
  Files          21       21              
  Lines        1516     1525       +9     
  Branches      273      275       +2     
==========================================
+ Hits         1463     1468       +5     
- Misses         33       36       +3     
- Partials       20       21       +1     
Flag Coverage Δ
unittests 96.00% <76.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seandstewart seandstewart merged commit f6d1eb2 into main Oct 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants