Skip to content

Commit

Permalink
Merge pull request #318 from hklion/docs
Browse files Browse the repository at this point in the history
add readmes to problems and tweak docs
  • Loading branch information
hklion authored Dec 18, 2024
2 parents 5d19c75 + 8edf33a commit e5ce15b
Show file tree
Hide file tree
Showing 11 changed files with 53 additions and 18 deletions.
2 changes: 0 additions & 2 deletions Docs/sphinx_doc/GettingStarted.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,3 @@ type:
.. include:: building.rst

.. include:: InputFiles.rst

.. include:: testing.rst
24 changes: 9 additions & 15 deletions Docs/sphinx_doc/Verification.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,67 +6,61 @@
Verification
============

The following test are used to verify the correct behavior of REMORA. Every problem below has a script ``test.sh``
The following test are used to verify the correct behavior of REMORA. Each problem below has a subdirectory in ``Exec``, which contains a sample ``inputs`` file and a ``README``, the contents of which are reproduced below:

.. _advection:

Advection
---------

The ``Advection`` problem tests scalar advection on a doubly-periodic domain with
flat bathymetry.
.. include:: ../../Exec/Advection/README


.. _channeltest:

Channel Test
------------

The reentrant channel test of [paper] is reproduced. This problem tests the development of turbulence and GLS mixing scheme. The [quantity] agrees with that from ROMS.

.. include:: ../../Exec/Channel_Test/README

.. _doublegyre:

Double Gyre
-----------

This reproduces the classic wind-driven double gyre problem, similar to the ROMS test problem by the same name.

.. include:: ../../Exec/DoubleGyre/README

.. _doublyperiodic:

Doubly Periodic
---------------

The basic version of this test simulates a flow with a depth-dependent horizontal velocity and temperature profile in a doubly-periodic domain with flat bathymetry. When non-flat bathymetry is used, the depth profile is the same as in the ROMS (and REMORA) Upwelling problem.
.. include:: ../../Exec/DoublyPeriodic/README

.. _idealminigrid:

Ideal Mini Grid
---------------

This small idealized grid is used to test netCDF-provided initial and boundary conditions. The ocean is initialized with zero velocity and a constant temperature and salinity. Time-varying boundary conditions are then applied for velocity, temperature, or salinity (provided by netCDF file). The default is to used a clamped boundary condition for all quantities, but options for Chapman-Flather and radiation conditions are available. This test also verifies correct behavior with land-sea masking when using the ``_masked`` grid file.

The netCDF files needed to run these tests can be found in the `remora-data <https://github.com/seahorce-scidac/remora-data>`_ repository under the ``IdealMiniGrid`` directory.
.. include:: ../../Exec/IdealMiniGrid/README.rst

.. _particlesseamount:

Particles Over Seamount
-----------------------

This problem tests advection of tracer particles on a flat domain.
.. include:: ../../Exec/ParticlesOverSeaMount/README

.. _seamount-desc:

Seamount
--------

The `Seamount <https://www.myroms.org/wiki/SEAMOUNT_CASE>`_ problem involves an (analytically) stably stratified fluid at rest over a seamount. In the absence of numerical errors, the fluid will remain at rest. However, this may not occur due to numerical errors in the calculation of the horizontal pressure gradient when the vertical coordinates are misaligned with the geopotential surfaces, as is the case in problems with spatially-varying bathymetry in ROMS/REMORA.

.. include:: ../../Exec/Seamount/README.rst

.. _upwelling-desc:

Upwelling
---------

The `Upwelling <https://www.myroms.org/wiki/UPWELLING_CASE>`_ demonstrates wind-driven upwelling over a perioidc channel. It closely matches the test problem by the same name in ROMS.
.. include:: ../../Exec/Upwelling/README.rst
2 changes: 1 addition & 1 deletion Docs/sphinx_doc/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
REMORA
------

REMORA is currently under development as a next-generation version of the Regional Ocean Modeling System (ROMS).
REMORA is currently under development as a next-generation version of the Regional Ocean Modeling System (ROMS). The source code repository is hosted on `Github <https://github.com/seahorce-scidac/REMORA>`_. Questions and issues with the code can be directed to the developers by opening an Issue on the Github page. See our `Contributing <https://github.com/seahorce-scidac/REMORA/blob/development/CONTRIBUTING.md>`_ page for how to contribute code to the repository.

REMORA is built on `AMReX <https://github.com/AMReX-Codes/amrex>`_,
an adaptive mesh refinement software framework, which provides the underlying software infrastructure for
Expand Down
6 changes: 6 additions & 0 deletions Exec/Advection/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
The Advection problem tests scalar advection of a gaussian concentration
distribution on a doubly-periodic domain with flat bathymetry.

The file called inputs contains the single-level version of this test. The
file called inputs_ml runs the problem with adaptive mesh refinement, refining
where the scalar has a value greater than 0.5.
3 changes: 3 additions & 0 deletions Exec/Channel_Test/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
This problem reproduces the reentrant channel test case from []. It tests
the development of turbulence and the GLS mixing scheme. The mean surface
kinetic energy agrees with that from ROMS.
2 changes: 2 additions & 0 deletions Exec/DoubleGyre/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The DoubleGyre problem reproduces the classic wind-driven double gyre problem,
similar to the ROMS test problem by the same name.
6 changes: 6 additions & 0 deletions Exec/DoublyPeriodic/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
The basic version of the DoublyPerioidic test simulates a flow with a
depth-dependent horizontal velocity and temperature profile in a
doubly-periodic domain with flat bathymetry. When non-flat bathymetry
is used, the depth profile is the same as in the ROMS (and REMORA)
Upwelling problem.

13 changes: 13 additions & 0 deletions Exec/IdealMiniGrid/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
This small idealized grid is used to test netCDF-provided initial and boundary
conditions. The ocean is initialized with zero velocity and a constant
temperature and salinity. Time-varying boundary conditions are then applied
for velocity, temperature, or salinity (provided by netCDF file). The default
is to used a clamped boundary condition for all quantities, but options for
Chapman-Flather and radiation conditions are available. This test also
verifies correct behavior with land-sea masking when using the ``_masked`` grid
file.

The netCDF files needed to run these tests can be found in the
`remora-data <https://github.com/seahorce-scidac/remora-data>`_
repository under the ``IdealMiniGrid`` directory.

1 change: 1 addition & 0 deletions Exec/ParticlesOverSeaMount/README
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This problem tests advection of tracer particles on a flat domain.
9 changes: 9 additions & 0 deletions Exec/Seamount/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
The Seamount problem is a standard test in
`ROMS <https://www.myroms.org/wiki/SEAMOUNT_CASE>`_.
The problem involves an (analytically) stably stratified fluid at rest over a
seamount. In the absence of numerical errors, the fluid will remain at rest.
However, this may not occur due to numerical errors in the calculation of the
horizontal pressure gradient when the vertical coordinates are misaligned with
the geopotential surfaces, as is the case in problems with spatially-varying
bathymetry in ROMS/REMORA.

3 changes: 3 additions & 0 deletions Exec/Upwelling/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The Upwelling problem is set up as in
`ROMS <https://www.myroms.org/wiki/UPWELLING_CASE>`_. It demonstrates
wind-driven upwelling over a perioidc channel.

0 comments on commit e5ce15b

Please sign in to comment.